This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
Fix lookup for stocks on named exchanges #1666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ':' in Google URL for suffixed stock (e.g. VOW.DE) but '.' in Yahoo URL. Also, remove 'http/https' prefix from ticker if present. Slack is an example where 'VOW.DE' is currently passed down as 'HTTP://VOW.DE' (wrongly, in my opinion).
| @@ -17,9 +17,9 @@ | |||
|
|
|||
| module.exports = (robot) -> | |||
| robot.respond /stock (?:info|price|quote)?\s?(?:for|me)?\s?@?([A-Za-z0-9.-_]+)\s?(\d+\w+)?/i, (msg) -> | |||
There was a problem hiding this comment.
This could also be changed to not interpret ".-" as a range from '.' to '' as it is now, but I felt it out of scope for this fix.
|
This repository has been deprecated for awhile in favor of npm packages. We are in the process of finding scripts that have been extracted, and deprecating them over in #1641 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ':' in Google URL for suffixed stock (e.g. VOW.DE) but '.' in Yahoo URL.
Also, remove 'http/https' prefix from ticker if present. Slack is an example where 'VOW.DE' is currently passed down as 'HTTP://VOW.DE' (wrongly, in my opinion).