Review hubot-scripts organization and npm for scripts that have been extracted

[technicalpickles]

As part of deprecating this repo, we'll want to find scripts that have been extracted, and prompt users to use those. When we get closer to turning this off, we can make it more forceful.

Some places to look:

• https://github.com/hubot-scripts
• https://github.com/hubot-scripts/packages/issues?q=is%3Aissue+is%3Aclosed
• npm search hubot-scripts

Example snippet for deprecation: https://github.com/github/hubot-scripts/blob/master/src/scripts/pagerduty.coffee#L61 (This is handled in hubot as of 2.19.0)

Running list of things to deprecate:

• 9gag: https://github.com/luijose/hubot-9gag
• asana: https://github.com/hubot-scripts/hubot-asana
• ascii: https://github.com/sanderploegsma/hubot-ascii-art
• banbang: https://www.npmjs.com/package/hubot-bang-bang
• coin: https://github.com/fordnox/hubot-coin
• darksky: https://github.com/hubot-scripts/hubot-darksky
• factoids: https://github.com/hubot-scripts/hubot-factoids
• gitlab for https://github.com/spruce/hubot-gitlab-hooks
• google: for https://github.com/mnpk/hubot-google
• isup: https://github.com/pric/hubot-isup
• jenkins: https://github.com/balbeko/hubot-jenkins
• jira-issues: https://github.com/rustedgrail/hubot-jira
• karma: https://github.com/notpeter/hubot-karma-classic
• meme_captain.coffee: cycomachead/hubot-meme
• resumator: https://github.com/ChrisMissal/hubot-resumator
• wolfram: https://github.com/notpeter/hubot-wolfram
• xkcd.coffee: https://www.npmjs.com/package/hubot-xkcd
• youtube-info: https://github.com/ClaudeBot/hubot-youtube-info
• s3-brain.coffee: https://github.com/dylanmei/hubot-s3-brain
• shipit.coffee: https://github.com/hubot-scripts/hubot-shipit
• aww: https://github.com/thejefe/hubot-aww

Known things without extractions:

• bing.coffee
• bang-bang.coffee
• python_library.coffee
• cowsay.coffee
• brewerydb.coffee (there's a npm package, but the GitHub repository was deleted, and README makes it look like it was something else)
• github-pulls.coffee
• graphite.coffee

cc @github/open-source-hubot-maintainers

[technicalpickles]

When new issues are opened, we should check to see if it's on a script that's been extracted. That'd give us a nice reactive list, without having to go through everything up front.

[notpeter]

I'm also maintaining the original Karma script (karma.coffee, not plusplus.coffee).
https://github.com/notpeter/hubot-karma-classic

[cycomachead]

I'm willing to move my package over to wherever it needs to be. I'm also probably going to work on my own hubot over the summer and will probably find reasons to fix scripts -- what should the process be for doing that? It seems like most scripts have an author, but not necessarily a maintainer, assuming I give credit to the original work, is there any harm in creating a new package, and the creating new PR's with deprecation warnings?

[cycomachead]

Some additional scripts to deprecate:

meme_captain.coffee → cycomachead/hubot-meme
xkcd.coffee → https://www.npmjs.com/package/hubot-xkcd

[ChrisMissal]

I moved resumator.coffee to it's own repo here: https://github.com/ChrisMissal/hubot-resumator

[technicalpickles]

#1697 adds a mapping of deprecated scripts in that package to external packages. Then hubotio/hubot#970 builds on this to display notices to users that they are using the deprecated thing with some actions to take. Unfortunately, the action for most people is going to be to try to find a replacement or maintain it themself, but the notice points to this issue for coordination.

[khera]

I was just directed here after an npm update and restart of my hubot. One of the scripts the warning message says has no replacement is "s3-brain.coffee", yet I see it linked above in the checklist. Is it supposed to detect these already, or is that still not an implemented feature?

edit: looks like the replacements.json file lists "s3-brain" instead of "s3-brain.cofee" as the key.

[jvarness]

@technicalpickles for brewerydb.coffee, I made a hubot package that uses untappd instead of brewerydb that can suggest random beers for you: https://github.com/jvarness/hubot-barkeep

This isn't a 100% like-for-like replacement, but it might be similar.

[jdoose]

jenkins-notifier -> https://github.com/halkeye/hubot-jenkins-notifier

[markspolakovs]

calm-down -> https://www.npmjs.com/package/hubot-calm-down

[mmwtsn]

redis-brain -> https://github.com/hubot-scripts/hubot-redis-brain

[iserko]

bitcoin -> https://www.npmjs.com/package/hubot-bitcoin
days_since -> https://www.npmjs.com/package/hubot-days_since
redis-brain -> https://www.npmjs.com/package/hubot-redis-brain
spotify -> https://www.npmjs.com/package/hubot-spotify