Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are broken due to failing transip provider tests #512

Closed
pavantc opened this issue Mar 10, 2020 · 5 comments · Fixed by #514
Closed

Tests are broken due to failing transip provider tests #512

pavantc opened this issue Mar 10, 2020 · 5 comments · Fixed by #514

Comments

@pavantc
Copy link
Contributor

pavantc commented Mar 10, 2020

Looks like the transip resources are down causing breakages in the tests:

...........................................................................................................................................................................................................................................................EEEE..........................................................................................
======================================================================
ERROR: test_apply (test_octodns_provider_transip.TestTransipProvider)
----------------------------------------------------------------------

http://www.transip.nl/soap seems to be inaccessible.

@olafz
Copy link

olafz commented Mar 10, 2020

TransIP changed their API on March 5th, 2020: https://www.transip.nl/nieuws/de-nieuwe-transip-rest-api-is-live/

Voor onze nieuwe API zijn we overgestapt van SOAP naar het REST-protocol. Dit houdt onder andere in dat de API voortaan JSON in plaats van XML returnt

Translation: the new API moved from SOAP to REST. This means - for example - that the API now returns JSON instead of XML.

Maybe some relevant information can be found on https://www.transip.nl/developers/ or https://github.com/transip or

cc @digi-talo

Re: benkonrath/transip-api#60

@ross
Copy link
Contributor

ross commented Mar 10, 2020

Thanks @olafz that's kind of what it looked like. Unfortunately it seems the most recent transip package in pypy is 1 year old and appears to use the soap interface https://pypi.org/project/transip/#history.

@olafz
Copy link

olafz commented Mar 10, 2020

@ross The repository itself looks kind-of alive though: https://github.com/benkonrath/transip-api. I just cross-referenced an issue there (the same cause); let's see if anything happens. Otherwise I might take a look myself when I have a bit more time.

@benkonrath
Copy link

I just released a new version (2.1.0) that should fix the issue (thanks to some help). You can try this version but the TransIP SOAP API has been thankfully deprecated and will be turned off at some point (I guess).

@ross
Copy link
Contributor

ross commented Mar 16, 2020

/cc #514 which bumps to 2.1.1 and backs out the removal of tests and coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants