Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.9.9 - 2019-11-04 - Python 3.7 Support
def __cmp__
with__eq__
and friends topreserve custom equality and ordering behaviors that are essential to
octoDNS's processes.
__eq__
and friends so thatthey're sortable in Python 3 now that those things are more strict. A few
places this required jumping through hoops of sorts. Thankfully our tests
are pretty thorough and caught a lot of issues and hopefully the whole
plan, review, apply process will backstop that.
ordering for a number of providers that just convert changes into API
calls as they come. Python 2 sets ordered consistently, Python 3 they do
not. 7958233
_mod_keyer
ordering wasn't 100% complete and thus unreliable andrandom in Python 3. This has been addressed and may result in value
reordering on next plan, no actual changes in behavior should occur.
incf.countryutils
(in pypi) was last released in 2009 is not python 3compatible (it's country data is also pretty stale.)
pycountry_convert
appears to have the functionality required to replace its usage so it has
been removed as a dependency/requirement.
and verify things that were run into during the Python 3 work
six
ing of things/cc #201 (comment)