Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel 0 9 9 #417

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Rel 0 9 9 #417

merged 2 commits into from
Nov 4, 2019

Conversation

ross
Copy link
Contributor

@ross ross commented Nov 4, 2019

v0.9.9 - 2019-11-04 - Python 3.7 Support

  • Extensive pass through the whole codebase to support Python 3
    • Tons of updates to replace def __cmp__ with __eq__ and friends to
      preserve custom equality and ordering behaviors that are essential to
      octoDNS's processes.
    • Quite a few objects required the addition of __eq__ and friends so that
      they're sortable in Python 3 now that those things are more strict. A few
      places this required jumping through hoops of sorts. Thankfully our tests
      are pretty thorough and caught a lot of issues and hopefully the whole
      plan, review, apply process will backstop that.
    • Explicit ordering of changes by (name, type) to address inconsistent
      ordering for a number of providers that just convert changes into API
      calls as they come. Python 2 sets ordered consistently, Python 3 they do
      not. 7958233
    • Route53 _mod_keyer ordering wasn't 100% complete and thus unreliable and
      random in Python 3. This has been addressed and may result in value
      reordering on next plan, no actual changes in behavior should occur.
    • incf.countryutils (in pypi) was last released in 2009 is not python 3
      compatible (it's country data is also pretty stale.) pycountry_convert
      appears to have the functionality required to replace its usage so it has
      been removed as a dependency/requirement.
    • Bunch of additional unit tests and supporting config to exercise new code
      and verify things that were run into during the Python 3 work
    • lots of sixing of things
  • Validate Record name & fqdn length

/cc #201 (comment)

@ross ross self-assigned this Nov 4, 2019
@ross ross merged commit 2ceb686 into master Nov 4, 2019
@ross ross deleted the rel-0-9-9 branch November 4, 2019 23:02
@ross ross mentioned this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant