Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rouge dependency doesn’t correctly syntax highlight ES6 string interpolation #318

Closed
kapowaz opened this issue Sep 6, 2016 · 1 comment

Comments

@kapowaz
Copy link

kapowaz commented Sep 6, 2016

The rouge dependency set by github-pages is at v1.11.1, which doesn’t include more recent fixes that enable supporting ES6 syntax highlighting. This means that for example:

return `${firstName} ${lastName}`;

…will highlight the backticks as errors.

@benbalter
Copy link
Contributor

Thanks @kapowaz. This is dependent and somewhat duplicative of jekyll/jekyll#5230. Once Rouge 2.x is supported upstream, we can update the dependency here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants