Don't load pretty-show/hscolour by default. (#226) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @mpickering pointed out, this breaks `new-repl` if you have multiple versions of `pretty-show` in your package store.
patrickt
changed the title
joshvera
approved these changes
Aug 27, 2019
Closed
robrix
reviewed
Aug 28, 2019
| @@ -1,6 +1,3 @@ | |||
| -- Load the pretty-show & hscolour packages for use with :pretty. | |||
| :set -package pretty-show -package hscolour | |||
|
|
|||
| -- See docs/💡ProTip!.md | |||
| :def! pretty \ _ -> return ":set -interactive-print Semantic.Util.Pretty.prettyShow" | |||
| :def! no-pretty \_ -> return ":set -interactive-print System.IO.print" | |||
There was a problem hiding this comment.
We should probably remove these, too, and the corresponding parts of the 💡ProTip! doc should be amended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @mpickering pointed out, this breaks
new-replif you havemultiple versions of
pretty-showin your package store.