Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of color.ui = auto #118

Merged
merged 1 commit into from
May 14, 2014
Merged

Remove mentions of color.ui = auto #118

merged 1 commit into from
May 14, 2014

Conversation

felipec
Copy link
Contributor

@felipec felipec commented May 5, 2014

This has been the default since v1.8.4.

Signed-off-by: Felipe Contreras felipe.contreras@gmail.com

This has been the default since v1.8.4.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
@matthewmccullough
Copy link

👍

@jordanmccullough and @brntbeer we do still have some students on 1.8.0 and earlier, but I've updated our pre-reqs for class to signal that 1.8.4 is what they should be on via https://github.com/github/training-web/pull/129 to http://training.github.com/articles/github-class-prerequisites/

@jordanmccullough
Copy link

Nice catch @felipec. I'm 👍 for keeping the Cheat Sheet and Slides nearer to the bleeding-edge than trailing with the older manual setup for color.ui. Removing this is a nice way of tidying up the docs.

@felipec
Copy link
Contributor Author

felipec commented May 10, 2014

Note that you don't need to bump the pre-requisites. If they use an old version of Git, they won't see the colors by default, but you can still follow the class just fine.

@brntbeer
Copy link
Member

I agree that they can follow the class just fine, however the experience is
degraded when we speak to colors in the class with diff'ing and looking at
graphs etc.

Good catch either way. We should just see how this does in classes by being
removed. are people asking more and more questions about "whoa how Did you
get those colors?" Or they'll have them already

On Sunday, May 11, 2014, Felipe Contreras notifications@github.com wrote:

Note that you don't need to bump the pre-requisites. If they use an old
version of Git, they won't see the colors by default, but you can still
follow the class just fine.


Reply to this email directly or view it on GitHubhttps://github.com//pull/118#issuecomment-42758125
.

Brent Beer
GitHub Training
http://training.github.com
https://github.com/brntbeer

@jordanmccullough jordanmccullough merged commit 5e3785b into github:master May 14, 2014
jordanmccullough pushed a commit that referenced this pull request May 14, 2014
Remove `color.ui auto` from materials and closes #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants