Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more information in query history view for Quick Eval #264

Closed
jcreedcmu opened this issue Mar 5, 2020 · 3 comments
Closed

Show more information in query history view for Quick Eval #264

jcreedcmu opened this issue Mar 5, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jcreedcmu
Copy link
Contributor

For quick query, we store (and show on demand) the exact entire query that was ran.

For ordinary queries, showing the text of the query might be confusing because the state of the libraries it depended on might have changed in the meantime.

For quick eval, there is nonetheless a piece of information that is relevant to show, but not so large that it is likely to confuse the user into thinking that that's all of the relevant information: the context of the token or line that quick eval was applied to. We could show this in the query history status line.

@jcreedcmu jcreedcmu added the enhancement New feature or request label Mar 5, 2020
@adityasharad
Copy link
Contributor

We do show filename:startline but I agree the selected token would also be neat (in the case of predicate names, expressions might be too long to display).

@aeisenberg
Copy link
Contributor

aeisenberg commented Mar 5, 2020 via email

@jcreedcmu
Copy link
Contributor Author

jcreedcmu commented Mar 6, 2020

Not a bad idea --- no richer hovers than a string, but we can set a tooltip.

export class TreeItem {
		...
		/**
		 * The tooltip text when you hover over this item.
		 */
		tooltip?: string | undefined;
		...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants