Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest Knockout #4299

Closed
githubbob42 opened this issue Nov 29, 2016 · 2 comments
Closed

Upgrade to latest Knockout #4299

githubbob42 opened this issue Nov 29, 2016 · 2 comments

Comments

@githubbob42
Copy link
Owner

Mingle Card: 4636
Narrative

As a developer, I can utilize the latest features of Knockout, so that I can make the world a better place.

Acceptance Criteria

All existing tests should pass.

Analysis

Update knockout library to latest version

I tried to set “ko.options.deferUpdates = true” in shell.js but that caused 61+ unit test to fail because notifications where being fired off at different times then they currently are.  

Per Tom let’s just upgrade to Knockout v3.4.1 and get any benefits from that and turn on deferedUpdates later.

Note that there was an error generated in the unit tests after initially upgrading but was fixed based on a comment by Michael Best  (knockout/knockout#1858 (comment))

Related Stories

[alpine_mobile/#4638] Enable deferedUpdates option in knockout v3.4.1

Tasks

{{ table query: SELECT Number, Name, Owner, 'Task Status' WHERE Type = Task and Story = THIS CARD ORDER BY Status }}

Defects

{{ table query: SELECT Number, Name, Owner, 'Status' WHERE Type = Defect and 'Related Story' = THIS CARD }}

Test Plan

@githubbob42
Copy link
Owner Author

Feature: #4223 Performance Work Q4 2016 (Mingle)

@githubbob42
Copy link
Owner Author

Pull Request #2135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant