Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Questions for Learning Engineering #91

Closed
7 of 8 tasks
brianamarie opened this issue Oct 11, 2018 · 5 comments
Closed
7 of 8 tasks

Questions for Learning Engineering #91

brianamarie opened this issue Oct 11, 2018 · 5 comments
Assignees
Labels
Learning Engineering HELP question Further information is requested

Comments

@brianamarie
Copy link
Contributor

brianamarie commented Oct 11, 2018

Hello @githubtraining/learning-engineering 👋Here is a list of the questions that I have for you about the security course. For all of these, it's OK if the answer is yes, no, or maybe someday. 👍

General

Events?

Getting & using relevant data

Flow

PDFs

  • Do users actually look at the PDFs? We don't know, we'll just need to create it Create PDF #26
@heiskr
Copy link
Contributor

heiskr commented Oct 11, 2018

When the course is 'ready', how do we go about moving it to production behind a feature flag?

We're planning to enable courses to toggle between private and public. I have that in progress and we're hoping to have that out by the end of the week.
https://github.com/github/learning-engineering/issues/63

@brianamarie
Copy link
Contributor Author

brianamarie commented Oct 11, 2018

@heiskr EDIT: I misread everything you said and sounds good. 👍 I was planning on putting this in production by the end of today behind a flag so we could test, is that possible?

@JasonEtco
Copy link
Contributor

@brianamarie yep - you'll just add it as a private course.

@brianamarie
Copy link
Contributor Author

@JasonEtco sounds good. The last 5 questions (and the PRs/issues linked to them) are the only things between me and this course being in deployment as a private course. 👍

This was referenced Oct 11, 2018
@brianamarie
Copy link
Contributor Author

I opened an issue for the last question, so this is good to close! #100

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Learning Engineering HELP question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants