Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building CMake without git isn't working #352

Closed
iam-peter opened this issue Sep 15, 2021 · 2 comments
Closed

Building CMake without git isn't working #352

iam-peter opened this issue Sep 15, 2021 · 2 comments

Comments

@iam-peter
Copy link

When trying to build this project via CMake with the repository not being checked out from git (e.g. downloaded as an archive) it won't build due to CMake grabbing version information from git

string(REGEX REPLACE "^([0-9]+)\\..*" "\\1" VERSION_MAJOR "${GitTagVersion}")
string(REGEX REPLACE "^[0-9]+\\.([0-9]+).*" "\\1" VERSION_MINOR "${GitTagVersion}")
string(REGEX REPLACE "^[0-9]+\\.[0-9]+\\.([0-9]+).*" "\\1" VERSION_PATCH "${GitTagVersion}")

It will throw the following error:

CMake Error at CMakeLists.txt:9 (project):
  VERSION "HEAD-HASH-NOTFOUND.HEAD-HASH-NOTFOUND.HEAD-HASH-NOTFOUND" format
@githubuser0xFFFF
Copy link
Owner

Thank you peter for this report. The CMake build files are a contribution from an ADS user. At the moment you can use CMake build only, if you checkout via Git. I will add this information to the documentation,

@githubuser0xFFFF
Copy link
Owner

Fixed in master with pull request #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants