Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unsubscribe from thread" button doesn't unsubscribe #1485

Closed
1 task done
y-nk opened this issue Aug 22, 2024 · 8 comments
Closed
1 task done

"Unsubscribe from thread" button doesn't unsubscribe #1485

y-nk opened this issue Aug 22, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@y-nk
Copy link

y-nk commented Aug 22, 2024

🔍 Is there already an issue for your problem?

  • I have checked older issues, open and closed

📝 Description

I've used the bell icon (unsubscribe from thread) to silence notifications of some PRs, but going to the github notification panel i can see that those PRs are still subscribed to notifications. i wonder if it's expected behavior or bug ; if the PAT can't do this, there should be some log somewhere to reflect the failure imho.

🪜 Steps To Reproduce

  1. click the bell icon next to a PR
  2. click the bell icon under the Gitify logo to go to the Github notification panel
  3. witness that the PR you silenced is still subscribed for notifications

Gitify Version

5.13.1

Operating System

macOS

GitHub Account

GitHub Cloud

📸 Screenshots

No response

@y-nk y-nk added the bug Something isn't working label Aug 22, 2024
@setchy
Copy link
Member

setchy commented Aug 22, 2024

Thanks for reporting @y-nk - is there any errors within your console logs or system logs that you can share?

@y-nk
Copy link
Author

y-nk commented Aug 23, 2024

i just checked the faq, found the network panel. the call fires well with a { ignored: true } payload

in gitify, click on the bell somewhere:
image

payload:
image

response:
image

i dont know if it's supposed to be, but { ignored: true } is sent and { ignored: false, subscribed: false } is received.

also, when clicking on the github notification panel, PR still shows in the list
image

and only disappear after selecting the PR in the list + clicking the "unsubscribe" button. said button fires a request to an internal github payload which seems to also call "unsubscribe"

@setchy
Copy link
Member

setchy commented Aug 27, 2024

@y-nk - I spent some time this morning trying to reproduce the above issue, but unfortunately could not.

I'm using v5.13.1 with GitHub Cloud. I was able to repeatedly unsubscribe from notifications via the Gitify interface (mixture of issues and discussions) and see the corresponding changes in the GitHub UI (both on the specific items page, and the notifications inbox).

@y-nk
Copy link
Author

y-nk commented Aug 28, 2024

@setchy thanks for spending the time in testing. i will look further again, reinstall and make sure all is well. i'm also using GitHub Cloud. I will close this as, since you can't reproduce, it's most likely that the problem is on my side.

@y-nk y-nk closed this as completed Aug 28, 2024
@setchy
Copy link
Member

setchy commented Aug 28, 2024

No worries - always happy to reopen this ticket if you are still having issues and we can continue to triage 🕵️

@y-nk
Copy link
Author

y-nk commented Aug 29, 2024

@setchy i think if i had to reopen it'd be to ask for a feature which is a button doing the 3 calls (mark as read, unsubscribe and silence mark as done) in one click 😬

@setchy
Copy link
Member

setchy commented Aug 29, 2024

@setchy i think if i had to reopen it'd be to ask for a feature which is a button doing the 3 calls (mark as read, unsubscribe and silence) in one click 😬

Maybe I'm missing something, but isn't this what happens today when you click the Unsubscribe from Thread notification icon in Gitify 🤔

@y-nk
Copy link
Author

y-nk commented Aug 30, 2024

@setchy my bad for bad english: clicking the bell (unsubscribe) doesn't "mark as done" in a batch (but i worked the habit of 2 clicks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants