Better encode #100

Merged
merged 2 commits into from Feb 26, 2013

Projects

None yet

2 participants

@cabeca

Moved the GitlabCi::Encode.encode! method call closer to the file read.
This keeps the boundary between "external file source with crazy
encoding -> internal rails code all in utf-8" well defined.
Additionally the build output file is opened in binary mode to prevent
encoding exceptions while reading it. It will be converted to utf-8 by
GitlabCi::Encode.encode!

cabeca added some commits Feb 2, 2013
@cabeca cabeca Removed initializer by moving require to encode lib where it belongs. 8846a19
@cabeca cabeca Refactored encoding of build output.
Moved the GitlabCi::Encode.encode! method call closer to the file read.
This keeps the boundary between "external file source with crazy
encoding -> internal rails code all in utf-8" well defined.
Additionally the build output file is opened in binary mode to prevent
encoding exceptions while reading it. It will be converted to utf-8 by
GitlabCi::Encode.encode!
3547111
@randx randx merged commit ad65ca3 into gitlabhq:master Feb 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment