This repository has been archived by the owner on May 12, 2018. It is now read-only.
Better encode #100
Merged
Better encode #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the GitlabCi::Encode.encode! method call closer to the file read. This keeps the boundary between "external file source with crazy encoding -> internal rails code all in utf-8" well defined. Additionally the build output file is opened in binary mode to prevent encoding exceptions while reading it. It will be converted to utf-8 by GitlabCi::Encode.encode!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the GitlabCi::Encode.encode! method call closer to the file read.
This keeps the boundary between "external file source with crazy
encoding -> internal rails code all in utf-8" well defined.
Additionally the build output file is opened in binary mode to prevent
encoding exceptions while reading it. It will be converted to utf-8 by
GitlabCi::Encode.encode!