Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Better encode #100

Merged
merged 2 commits into from Feb 26, 2013
Merged

Better encode #100

merged 2 commits into from Feb 26, 2013

Commits on Feb 2, 2013

  1. Removed initializer by moving require to encode lib where it belongs.

    @cabeca
    cabeca committed Feb 2, 2013
    Copy the full SHA
    8846a19 View commit details
    Browse the repository at this point in the history

  2. Refactored encoding of build output. 

    Moved the GitlabCi::Encode.encode! method call closer to the file read.
This keeps the boundary between "external file source with crazy
encoding -> internal rails code all in utf-8" well defined.
Additionally the build output file is opened in binary mode to prevent
encoding exceptions while reading it. It will be converted to utf-8 by
GitlabCi::Encode.encode!
    @cabeca
    cabeca committed Feb 2, 2013
    Copy the full SHA
    3547111 View commit details
    Browse the repository at this point in the history