Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The method that check wether /etc/init.d/gitlab is up-to-date is not right on CentOS #159

Closed
jlumqz opened this issue Nov 10, 2013 · 2 comments

Comments

@jlumqz
Copy link
Contributor

jlumqz commented Nov 10, 2013

To do this, gitlab noly checks if the file '/etc/init.d/gitlab' is same with 'lib/support/init.d/gitlab"'. This is right when we use ubuntu. When we install gitlab on CentOS, we download the file from https://github.com/gitlabhq/gitlab-recipes/tree/master/init/sysvinit/centos/gitlab-unicorn, so it is not same with 'lib/support/init.d/gitlab', then the command 'bundle exec rake gitlab:check RAILS_ENV=production' said '/etc/init.d/gitlab' is not up-to-date.

@axilleas
Copy link
Contributor

That is true, but not a problem with CentOS recipe rather than the rake task that runs that check. Keep in mind that the official installation supports debian/ubuntu only.

One thing I can think of is to inform the users about that issue in the README guide. Care to make a PR?

@jlumqz
Copy link
Contributor Author

jlumqz commented Nov 11, 2013

OK! I will add something in README this night, then I will give you a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants