Gitlab/Gitolite: Support anonymous access through the git daemon

app/contexts/project_update_context.rb

@@ -16,8 +16,13 @@ def execute(role = :default)
         project.transfer(namespace)
       end
     end
-
-    project.update_attributes(params[:project], as: role)
+
+    if params[:project]["anon_clone"].to_i.zero? == project.anon_clone
+      project.update_attributes(params[:project], as: role)
+      project.update_repository
+    else
+      project.update_attributes(params[:project], as: role)
+    end
   end
 end
 

app/models/project.rb

@@ -9,6 +9,7 @@
 #  created_at             :datetime         not null
 #  updated_at             :datetime         not null
 #  private_flag           :boolean          default(TRUE), not null
+#  anon_clone             :boolean          default(FALSE), not null
 #  owner_id               :integer
 #  default_branch         :string(255)
 #  issues_enabled         :boolean          default(TRUE), not null
@@ -30,7 +31,7 @@ class Project < ActiveRecord::Base
   class TransferError < StandardError; end
 
   attr_accessible :name, :path, :description, :default_branch, :issues_enabled,
-                  :wall_enabled, :merge_requests_enabled, :wiki_enabled, as: [:default, :admin]
+                  :wall_enabled, :merge_requests_enabled, :wiki_enabled, :anon_clone, as: [:default, :admin]
 
   attr_accessible :namespace_id, :owner_id, as: :admin
 
@@ -69,7 +70,7 @@ class TransferError < StandardError; end
             format: { with: Gitlab::Regex.path_regex,
                       message: "only letters, digits & '_' '-' '.' allowed. Letter should be first" }
   validates :issues_enabled, :wall_enabled, :merge_requests_enabled,
-            :wiki_enabled, inclusion: { in: [true, false] }
+            :wiki_enabled, :anon_clone, inclusion: { in: [true, false] }
 
   validates_uniqueness_of :name, scope: :namespace_id
   validates_uniqueness_of :path, scope: :namespace_id

app/roles/repository.rb

@@ -201,6 +201,10 @@ def ssh_url_to_repo
   def http_url_to_repo
     http_url = [Gitlab.config.gitlab.url, "/", path_with_namespace, ".git"].join('')
   end
+
+  def gitd_url_to_repo
+    gitd_url = http_url_to_repo.gsub(/^.+:\/\//,'git://')
+  end
 
   # Check if current branch name is marked as protected in the system
   def protected_branch? branch_name

app/views/admin/projects/_form.html.haml

@@ -42,6 +42,10 @@
     .clearfix
       = f.label :wiki_enabled, "Wiki"
       .input= f.check_box :wiki_enabled
+
+    .clearfix
+      = f.label :anon_clone, "Anonymous clone via Git Daemon protocol"
+      .input= f.check_box :anon_clone
 
   %fieldset.features
     %legend Transfer:

app/views/admin/projects/show.html.haml

@@ -89,6 +89,12 @@
         SSH:
     %td
       = link_to @project.ssh_url_to_repo
+  %tr
+    %td
+      %b
+        Git Read-Only:
+    %td
+      = link_to @project.gitd_url_to_repo
   %tr
     %td
       %b

app/views/projects/_form.html.haml

@@ -49,7 +49,12 @@
       .controls
         = f.check_box :wiki_enabled
         %span.descr Pages for project documentation
-
+
+    .control-group
+      = f.label :anon_clone, "Anonymous Git Clone", class: 'control-label'
+      .controls
+        = f.check_box :anon_clone
+        %span.descr Enables anonymous cloning of the repository over the git:// protocol
 
   - if can? current_user, :change_namespace, @project
     %fieldset.features

app/views/shared/_clone_panel.html.haml

@@ -1,4 +1,6 @@
 .input-prepend.project_clone_holder
   %button{class: "btn active", :"data-clone" => @project.ssh_url_to_repo} SSH
   %button{class: "btn", :"data-clone" => @project.http_url_to_repo}= Gitlab.config.gitlab.protocol.upcase
+  - if @project.anon_clone? 
+    %button{class: "btn", :"data-clone" => @project.gitd_url_to_repo} Git Read-Only
   = text_field_tag :project_clone, @project.url_to_repo, class: "one_click_select input-xxlarge"

db/migrate/20130110143240_add_anon_clone_to_projects.rb

@@ -0,0 +1,5 @@
+class AddAnonCloneToProjects < ActiveRecord::Migration
+  def change
+    add_column :projects, :anon_clone, :boolean, :default => false, :null => false
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
 
-ActiveRecord::Schema.define(:version => 20121219095402) do
+ActiveRecord::Schema.define(:version => 20130110143240) do
 
   create_table "events", :force => true do |t|
     t.string   "target_type"
@@ -155,6 +155,7 @@
     t.boolean  "merge_requests_enabled", :default => true, :null => false
     t.boolean  "wiki_enabled",           :default => true, :null => false
     t.integer  "namespace_id"
+    t.boolean  "anon_clone",             :default => false, :null => false
   end
 
   add_index "projects", ["namespace_id"], :name => "index_projects_on_namespace_id"

doc/install/installation.md

@@ -330,6 +330,12 @@ Make sure to edit the config file to match your setup:
 
     sudo /etc/init.d/nginx restart
 
+# 8. Anonymous Git access (optional)
+
+Configure your git daemon instance to point to /home/git/repositories and
+ensure it executes as the same user as gitolite does to avoid any possible
+issues.
+
 
 # Done!
 

lib/api/projects.rb

@@ -33,6 +33,7 @@ class Projects < Grape::API
       #   wall_enabled (optional) - enabled by default
       #   merge_requests_enabled (optional) - enabled by default
       #   wiki_enabled (optional) - enabled by default
+      #   anon_clone (optional) - disabled by default
       # Example Request
       #   POST /projects
       post do
@@ -42,7 +43,8 @@ class Projects < Grape::API
                                     :issues_enabled,
                                     :wall_enabled,
                                     :merge_requests_enabled,
-                                    :wiki_enabled]
+                                    :wiki_enabled,
+                                    :anon_clone]
         @project = Project.create_by_user(attrs, current_user)
         if @project.saved?
           present @project, with: Entities::Project

lib/gitlab/backend/gitolite.rb

@@ -44,6 +44,10 @@ def url_to_repo path
     def enable_automerge
       config.admin_all_repo!
     end
+
+    def set_anonclone allowed
+      config.set_anonclone(allowed)
+    end
 
     def update_repositories projects
       config.apply do |config|

lib/gitlab/backend/gitolite_config.rb

@@ -129,7 +129,7 @@ def update_projects(projects)
       end
     end
 
-    def update_project_config(project, conf)
+    def update_project_config(project, conf, anon_clone = project.anon_clone)
       repo_name = project.path_with_namespace
 
       repo = if conf.has_repo?(repo_name)
@@ -157,9 +157,14 @@ def update_project_config(project, conf)
       # Add write permissions
       repo.add_permission("RW+", "", name_writers) unless name_writers.blank?
       repo.add_permission("RW+", "", name_masters) unless name_masters.blank?
-
-      # Add sharedRepository config
-      repo.set_git_config("core.sharedRepository", "0660")
+
+      # Check Anon cloning and set appropriate permissions
+      if anon_clone
+        repo.add_permission("R", "", "daemon")
+        repo.set_git_config("core.sharedRepository", "0664")
+      else
+        repo.set_git_config("core.sharedRepository", "0660")
+      end
 
       repo
     end