New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify squash comes after review. #7257

Merged
merged 1 commit into from Jul 16, 2014

Conversation

3 participants
@cirosantilli
Contributor

cirosantilli commented Jul 4, 2014

So people don't focus on writing good commit messages for a bunch of unrelated fixes.

Clariy squash comes after review.
So people don't focus on writing good commit messages for a bunch of unrelated fixes.
@TeatroIO

This comment has been minimized.

TeatroIO commented Jul 4, 2014

I've prepared a stage. Click to open.

@jvanbaarsen

This comment has been minimized.

Contributor

jvanbaarsen commented Jul 16, 2014

@cirosantilli Thanks!

jvanbaarsen added a commit that referenced this pull request Jul 16, 2014

Merge pull request #7257 from cirosantilli/patch-4
Clariy squash comes after review.

@jvanbaarsen jvanbaarsen merged commit d5d6fc3 into gitlabhq:master Jul 16, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@cirosantilli cirosantilli deleted the cirosantilli:patch-4 branch Jul 16, 2014

@cirosantilli cirosantilli changed the title from Clariy squash comes after review. to Clarify squash comes after review. Jul 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment