Only clone GitLab Shell on tests if necessary. #7823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage. Click to open. |
| unless File.directory?(Gitlab.config.gitlab_shell.path) | ||
| %x[rake gitlab:shell:install] | ||
| end | ||
| %x[rake gitlab:shell:install] |
There was a problem hiding this comment.
Do not use %x unless the command string contains backquotes.
cirosantilli
force-pushed
the
test-fetch-shell
branch
from
04a71bc
to
065ab3e
Compare
|
@cirosantilli nice! |
dzaporozhets
added a commit
that referenced
this pull request
Sep 24, 2014
Only clone GitLab Shell on tests if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
tmp/testgot removed before every time we started running tests, and we had to clone GitLab Shell again.Now:
tmp/test/gitlab-shellis not removed before tests, only the other siblingsUse case: allow to run tests without the Internet (airplane, commuting, internet problems, GitLab.com downtime, etc.)
There is only one more Internet dependency: cloning
gitlab-test, but that one is harder to deal with since all branches must be synced.Still, this change already makes testing a bit faster and walks towards that goal.
Implementation notes:
unless File.directory?: removed because was never used becauserm_rfalways removedtests, and should not be used in theory either, since if the repository is there we might want to fetch.