Titleize blob action buttons. [failure unrelated] #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've prepared a stage. Click to open. |
cirosantilli
force-pushed
the
titleize-actions
branch
from
5408088
to
a61b6b5
Compare
| step 'I click link "raw"' do | ||
| click_link "raw" | ||
| step 'I click link "Raw"' do | ||
| click_link "Raw" |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
cirosantilli
force-pushed
the
titleize-actions
branch
from
a61b6b5
to
f9fd6da
Compare
|
@cirosantilli Can you take a look on the failing testcases? |
cirosantilli
force-pushed
the
titleize-actions
branch
from
f9fd6da
to
e5c0461
Compare
cirosantilli
changed the title
cirosantilli
force-pushed
the
titleize-actions
branch
2 times, most recently
from
df25335
to
6200709
Compare
cirosantilli
changed the title
cirosantilli
force-pushed
the
titleize-actions
branch
3 times, most recently
from
c719230
to
75bb86a
Compare
cirosantilli
changed the title
cirosantilli
force-pushed
the
titleize-actions
branch
from
75bb86a
to
0d4ae0e
Compare
cirosantilli
changed the title
|
👍 |
Razer6
added a commit
that referenced
this pull request
Oct 1, 2014
Titleize blob action buttons. [failure unrelated]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As supported by dosire at: https://github.com/gitlabhq/gitlabhq/issues/7789#issuecomment-57126623
I think it looks better.
After:
Before:
In particular, those buttons being lower case already conflicts with the analogous buttons on merge request diffs.
Also titleized the history link on the tree view: it makes tests simpler, and would have to be done sooner or later. Screenshot (link on upper right):