New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Titleize blob action buttons. [failure unrelated] #7904

Merged
merged 1 commit into from Oct 1, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Sep 29, 2014

As supported by dosire at: https://github.com/gitlabhq/gitlabhq/issues/7789#issuecomment-57126623

I think it looks better.

After:

screenshot from 2014-09-29 23 10 14 upcase actions

Before:

screenshot from 2014-09-29 23 12 03 titleize blob action before

In particular, those buttons being lower case already conflicts with the analogous buttons on merge request diffs.

Also titleized the history link on the tree view: it makes tests simpler, and would have to be done sooner or later. Screenshot (link on upper right):

screenshot from 2014-09-30 23 30 15 project tree history

@TeatroIO

This comment has been minimized.

TeatroIO commented Sep 29, 2014

I've prepared a stage. Click to open.

@cirosantilli cirosantilli force-pushed the cirosantilli:titleize-actions branch from 5408088 to a61b6b5 Sep 29, 2014

step 'I click link "raw"' do
click_link "raw"
step 'I click link "Raw"' do
click_link "Raw"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

step 'I click blame button' do
click_link "blame"
step 'I click Blame button' do
click_link "Blame"

This comment has been minimized.

@houndci-bot

houndci-bot Sep 29, 2014

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@cirosantilli cirosantilli force-pushed the cirosantilli:titleize-actions branch from a61b6b5 to f9fd6da Sep 29, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Sep 30, 2014

@cirosantilli Can you take a look on the failing testcases?

@cirosantilli cirosantilli force-pushed the cirosantilli:titleize-actions branch from f9fd6da to e5c0461 Sep 30, 2014

@cirosantilli cirosantilli changed the title from Titleize blob action buttons. to [WIP] Titleize blob action buttons. Sep 30, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:titleize-actions branch 2 times, most recently to 6200709 Sep 30, 2014

@cirosantilli cirosantilli changed the title from [WIP] Titleize blob action buttons. to Titleize blob action buttons. Sep 30, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:titleize-actions branch 3 times, most recently from c719230 to 75bb86a Sep 30, 2014

@cirosantilli cirosantilli changed the title from Titleize blob action buttons. to [WIP] Titleize blob action buttons. Sep 30, 2014

@cirosantilli cirosantilli force-pushed the cirosantilli:titleize-actions branch from 75bb86a to 0d4ae0e Sep 30, 2014

@cirosantilli cirosantilli changed the title from [WIP] Titleize blob action buttons. to Titleize blob action buttons. [failure unrelated] Oct 1, 2014

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 1, 2014

👍

Razer6 added a commit that referenced this pull request Oct 1, 2014

Merge pull request #7904 from cirosantilli/titleize-actions
Titleize blob action buttons. [failure unrelated]

@Razer6 Razer6 merged commit 350877d into gitlabhq:master Oct 1, 2014

1 check failed

default The build failed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:titleize-actions branch Oct 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment