Use argument list for sh instead of string #8088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faster, more portable and less error prone since no shell expansion.
|
I've prepared a stage. Click to open. |
|
@jacobvosmaer Looks good from my side. Do you also agree? |
jacobvosmaer
added a commit
that referenced
this pull request
Oct 23, 2014
Use argument list for sh instead of string
rspeicher
pushed a commit
that referenced
this pull request
Apr 17, 2018
Embedded Snippets Support Closes #8088 See merge request gitlab-org/gitlab-ce!15695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster, more portable and less error prone since no shell expansion.