New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use argument list for sh instead of string #8088

Merged
merged 1 commit into from Oct 23, 2014

Conversation

4 participants
@cirosantilli
Contributor

cirosantilli commented Oct 18, 2014

Faster, more portable and less error prone since no shell expansion.

Use argument list for sh instead of string
Faster, more portable and less error prone since no shell expansion.
@TeatroIO

This comment has been minimized.

TeatroIO commented Oct 18, 2014

I've prepared a stage. Click to open.

@Razer6

This comment has been minimized.

Member

Razer6 commented Oct 23, 2014

@jacobvosmaer Looks good from my side. Do you also agree?

jacobvosmaer added a commit that referenced this pull request Oct 23, 2014

Merge pull request #8088 from cirosantilli/sh-str-to-args
Use argument list for sh instead of string

@jacobvosmaer jacobvosmaer merged commit 90e960f into gitlabhq:master Oct 23, 2014

1 check passed

default The build passed on Semaphore.
Details

@cirosantilli cirosantilli deleted the cirosantilli:sh-str-to-args branch Oct 23, 2014

rspeicher pushed a commit that referenced this pull request Apr 17, 2018

Merge branch '8088_embedded_snippets_support' into 'master'
Embedded Snippets Support

Closes #8088

See merge request gitlab-org/gitlab-ce!15695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment