Check browser version, blacklisting outdated IE #8385
Conversation
|
I've prepared a stage. Click to open. |
vicvega
force-pushed
the
check_browser_version
branch
from
2d5ca39
to
b5823ec
Compare
|
Replaces #8348. |
| padding: 10px; | ||
| text-align: center; | ||
| background: #C67; | ||
| // background: #F51; |
vicvega
force-pushed
the
check_browser_version
branch
from
da42dde
to
b992735
Compare
|
I also rebased on current master to make it mergeable @randx let me know if I can do something else |
|
@vicvega Can you squash the commits to one commit? |
vicvega
force-pushed
the
check_browser_version
branch
3 times, most recently
from
241223c
to
1c30934
Compare
|
@jvanbaarsen I've squashed the commits and rebased on current master |
jvanbaarsen
added
Ready for Merge
and removed
Awaiting developer action/feedback
labels
|
@vicvega Thanks! |
|
Linking to the original issue where Dmitriy and myself commented. #7597 I think this PR gets pretty close to what we talked about. The only thing is Dmitriy suggested IE 6-7 and lower and this is for 10 and lower. I'm torn on these type of warnings. There's nothing more annoying than a 'browser may be incompatible' message IMHO. Should we make this warning dismiss-able? How broken is IE 10 and lower with current GitLab? |
|
@dblessing I know that IE 8 and IE9 also giving trouble from time to time, I think we should give this warning to at least ie 6/7 and 8 users. And preferably IE9. |
|
@dblessing with IE8 (unfortunately still present in my company) gitlab is totally unusable Here is how it looks like It is all messed up, with several javascript errors... and here is the same page (not joking, it is really the same page!) in firefox 34 |
|
How about keeping the message for all versions through IE 10 but making it dismissible like the SSH keys message? |
|
@bbodenmiller Well, I really think this is an important notice. So being able to dismiss the notice will have the effect that people dismiss the notice, and after a while forget that they use a crappy browser, and start reporting bugs that are no bugs but just the result of using a crappy browser. What do you guys think about trying out the permanent notice, if we get comments about it being really annoying, we can change it in a future release. |
|
👍 |
It's exactly what happened in my company 😄 I totally agree with @jvanbaarsen |
|
@vicvega Can you please make sure its mergeable (sorry :( )? |
vicvega
force-pushed
the
check_browser_version
branch
from
1c30934
to
6d5613e
Compare
|
@jvanbaarsen done (it was just the changelog) |
|
hmmm tests are failing?!!? @jvanbaarsen, is there something nasty on current master? |
|
@vicvega Nah sometimes Semaphore is having hick-ups, i restarted the build for you. Im also looking into this issue since i see a rise in failing builds last day. |
|
@jvanbaarsen ok good |
vicvega
force-pushed
the
check_browser_version
branch
from
6d5613e
to
c1ab964
Compare
|
just rebased on current master hmmm |
vicvega
force-pushed
the
check_browser_version
branch
from
c1ab964
to
84b40a3
Compare
|
I forced another push and all test are passing now anyway merry xmas! |
Check browser version Fix conflicts and merge #8385 See merge request !1357
Add an alert message in case of outdated browser.
Quite the same as #7597, but implementing a blacklist for outdated IE (version < 10)