Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set-output command #100

Closed
zricethezav opened this issue Oct 14, 2022 · 4 comments · Fixed by #101
Closed

Update set-output command #100

zricethezav opened this issue Oct 14, 2022 · 4 comments · Fixed by #101

Comments

@zricethezav
Copy link
Collaborator

From the nightly run: https://github.com/gitleaks/gitleaks-action/actions/runs/3247466866

gitleaks-action-HEAD
The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

cc @weineran

@weineran
Copy link
Contributor

Also here: https://github.com/gitleaks/gitleaks-action/actions/runs/3229579925

But I am confused b/c I don't see us using set-output anywhere, do you? I also don't see it in the checkout action we're using. But maybe I'm just not looking in the right place...?

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Oct 16, 2022

It looks like set-output is used in gitleaks.js#L124. Upgrading @actions/core to v1.10.0 should resolve the warning (see also the @actions/core release notes).

I submitted a Pull Request for this change.

@weineran
Copy link
Contributor

Great find @ericcornelissen! We'll take a look at your PR. Thank you!

@weineran
Copy link
Contributor

Resolved by #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants