Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import GitHub App installations to Projects #4661

Closed
AlexTugarev opened this issue Jun 30, 2021 · 5 comments
Closed

Import GitHub App installations to Projects #4661

AlexTugarev opened this issue Jun 30, 2021 · 5 comments

Comments

@AlexTugarev
Copy link
Member

The problem to solve is to streamline the Gitpod App installation for prebuilds. Now that we introduce Projects to be associated with installations of the prebuild app, we might think of migrating the "old style" entries in the DB. Maintaining both adds unwanted complexity to the handling of prebuilds at least.

One idea is to create projects for the currently active installations and add the installers as owner of the team to be created in the same process.

@svenefftinge
Copy link
Member

svenefftinge commented Jul 5, 2021

Can you share more information about what the problem is you want to solve? Having an installation stored separated from the project makes a lot of sense. What is "old style"?

@AlexTugarev AlexTugarev changed the title Migrate GitHub App installations to Projects Import GitHub App installations to Projects Jul 6, 2021
@AlexTugarev
Copy link
Member Author

Having an installation stored separated from the project makes a lot of sense.

We started out with storing the App installation ID attached to the project. Now that you are asking, I don't see a good reason to drop the extra sink for the installation.

Technically, the only thing to clean up would be the pending state of App installations, which we would drop eventually.

@jankeromnes
Copy link
Contributor

Now that you are asking, I don't see a good reason to drop the extra sink for the installation.

Hmm, but does this mean that we no longer want to migrate the "old style" entries in the DB? (I.e. close this issue for now.)

From really far away, it seems unnecessary to me to "automagically" create new Projects & Teams for current installations. Better let users do that action explicitly (it's easy to create Project even if you already have the app installed, right?)

Are there really two pathways that add complexity to prebuilds? 🤔 Could be worth discussing in a call.

@AlexTugarev
Copy link
Member Author

it's easy to create Project even if you already have the app installed, right?

have you tried that already?

Given the known issues with "OAuth vs GH-App", I'd see a fraction of installers not being able to see their installation in the New Project wizard. Importing as personal Project would remove that risk.

Are there really two pathways that add complexity to prebuilds?

Which complexity do you mean? We already have the association of prebuilds to projects in place, the rest remains as is.

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 6, 2021

Closing this, following the update in #5076 (comment).

@gtsiolis gtsiolis closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants