Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github hover link on workspaces page #8779

Closed
octemist opened this issue Mar 13, 2022 · 2 comments
Closed

Github hover link on workspaces page #8779

octemist opened this issue Mar 13, 2022 · 2 comments
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@octemist
Copy link

Is your feature request related to a problem? Please describe

On the /workspaces page when I go to click my workspace there's a github link beneath it which has some kind of title which covers the link I'm trying to click. It happens nearly every time which can be several times a day. It's really annoying, particularly as the github link seems to be there twice which seems unnecessary.

Describe the behaviour you'd like

Hopefully the hover-over can be removed, or the entire link for that matter.

Describe alternatives you've considered

None.

Additional context

Happens on desktop view.

@axonasif axonasif added type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Mar 13, 2022
@geropl
Copy link
Member

geropl commented Mar 14, 2022

@gtsiolis I faintly recall we're aware of this and already have an issue, but I cannot find it. Do you know where that was? If yes: Can you close this?

@gtsiolis
Copy link
Contributor

gtsiolis commented May 4, 2022

@geropl I had a note somewhere to come back to this.

We added this tooltip (title) back in #5323 to avoid hiding with truncation the full repository URL, see #8686 (comment):

FWIW, the tooltip on the project (repository URL) was added back in #5323 as a boring (simple) solution and a two-way door decision which we can safely remove in the future, see #5122 (comment). 💭

In some cases, middle truncation could help, see #5122 (comment). 💡

Re-posting from the same comment in #8686 (comment):

For points [1] and [2] I'd say improving the design of the Workspaces page is a good way forward. This could include removing duplicate information that is currently truncated, dropping any unnecessary elements, replacing long repository URLs with project links when possible, etc.

I'll close this in favor of #8686. Cc @octemist

@gtsiolis gtsiolis closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: No status
Development

No branches or pull requests

4 participants