Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh repository and profile by pulling down #103

Closed
andrewda opened this issue Jul 17, 2017 · 3 comments
Closed

Refresh repository and profile by pulling down #103

andrewda opened this issue Jul 17, 2017 · 3 comments
Labels
assigned enhancement has pr

Comments

@andrewda
Copy link
Member

It would be nice to be able to refresh a repository or a profile by pulling down. Would be useful for updating new issues on repos or updating followers on profiles.

pulldown.gif
@housseindjirdeh
Copy link
Member

Ooh this would definitely be nice to have. There's a RefreshControl method we can attach to the scrollview (http://facebook.github.io/react-native/releases/0.46/docs/scrollview.html#refreshcontrol) and when the screen is pulled we can just call the getRepository call again.

@SammyIsra
Copy link
Member

I can try this out if no one else is already on this

@andrewda
Copy link
Member Author

Awesome, thanks @SammyIsra!!

@SammyIsra SammyIsra mentioned this issue Jul 20, 2017
Merged
housseindjirdeh pushed a commit that referenced this issue Jul 31, 2017
@SammyIsra
Pull down to refresh implemented (#132)
b7fb8f8 
* Added react-native-cli to avoid onboarding issues in the future

* Pull down to refresh implemented in profile page

* Pull down to refresh implemented in Repository page. Closes #103.

* Fixed some merge issues

* Fixing some more merging issues

* Forgot to add myself as a contributor.

* Fetching user data and fetching repository data have been moved into their own functions.

* Fixed some merge issues.

* Renamed the function that fetches the information to be a bit more descriptive

* Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor.

* Fixed some merge issues, _again_

* Added pull to refresh to the non auth profile screen. Other minor improv.

* Fixing indentation inside of `<ScrollView />`

* Removing extra newline

* Adding a newline between our components and vendor components.

* Added myself as a contributor. Code and Bug Reports

* Valid NPM versions need to include three parts (x.y.z)

* Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh.

* Pull down to refresh now in Issue/PR page (comment list)

* Fixed some merging issues and yarn lockfile

* Organizations are now refreshable

* Better behavior on the AuthUser pull to refresh

* Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile

* Refreshing on Issues (specifically) works again

* Used '!!' instead of '|| false' as per suggestion 

Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined.
andrewda pushed a commit that referenced this issue Aug 2, 2017
@SammyIsra @andrewda
Pull down to refresh implemented (#132)
3e11d41 
* Added react-native-cli to avoid onboarding issues in the future

* Pull down to refresh implemented in profile page

* Pull down to refresh implemented in Repository page. Closes #103.

* Fixed some merge issues

* Fixing some more merging issues

* Forgot to add myself as a contributor.

* Fetching user data and fetching repository data have been moved into their own functions.

* Fixed some merge issues.

* Renamed the function that fetches the information to be a bit more descriptive

* Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor.

* Fixed some merge issues, _again_

* Added pull to refresh to the non auth profile screen. Other minor improv.

* Fixing indentation inside of `<ScrollView />`

* Removing extra newline

* Adding a newline between our components and vendor components.

* Added myself as a contributor. Code and Bug Reports

* Valid NPM versions need to include three parts (x.y.z)

* Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh.

* Pull down to refresh now in Issue/PR page (comment list)

* Fixed some merging issues and yarn lockfile

* Organizations are now refreshable

* Better behavior on the AuthUser pull to refresh

* Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile

* Refreshing on Issues (specifically) works again

* Used '!!' instead of '|| false' as per suggestion 

Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined.
housseindjirdeh pushed a commit that referenced this issue Aug 16, 2017
@SammyIsra
feat(repo): add label to show watch status (#227)
e2e993e 
* Added react-native-cli to avoid onboarding issues in the future

* Pull down to refresh implemented in profile page

* Pull down to refresh implemented in Repository page. Closes #103.

* Fixed some merge issues

* Fixing some more merging issues

* Forgot to add myself as a contributor.

* Fetching user data and fetching repository data have been moved into their own functions.

* Fixed some merge issues.

* Renamed the function that fetches the information to be a bit more descriptive

* Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor.

* Fixed some merge issues, _again_

* Added pull to refresh to the non auth profile screen. Other minor improv.

* Fixing indentation inside of `<ScrollView />`

* Removing extra newline

* Adding a newline between our components and vendor components.

* Added myself as a contributor. Code and Bug Reports

* Valid NPM versions need to include three parts (x.y.z)

* Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh.

* Pull down to refresh now in Issue/PR page (comment list)

* Fixed some merging issues and yarn lockfile

* Organizations are now refreshable

* Better behavior on the AuthUser pull to refresh

* Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile

* Refreshing on Issues (specifically) works again

* Used '!!' instead of '|| false' as per suggestion 

Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined.

* Add a (watching) label that shows when a user is watching a repo already.

* Fixed to look like gitpoint/master

* feat(repository): fixed location of Watchers label

* Minor code change to keep consistent with the style of the rest of the repo
reyhansofian added a commit to reyhansofian/git-point that referenced this issue Aug 16, 2017
@reyhansofian
merge master (#1)
42cb797 
* docs(README.md): add translation instruction (gitpoint#255)

* chore(commit): Make the repo Commitizen-friendly (gitpoint#240)

* chore(commit): Make the repo Commitizen-friendly

* docs(contributors): change my profile url

* docs(CONTRIBUTING.md): add information about Commitizen

* docs(CONTRIBUTING.md): move translations snippet

* docs(CONTRIBUTING.md): update commitzen snipper grammar

* fix(comment-input): add new lines when writing issue comments on Android (gitpoint#207)

* feat(repo): add label to show watch status (gitpoint#227)

* Added react-native-cli to avoid onboarding issues in the future

* Pull down to refresh implemented in profile page

* Pull down to refresh implemented in Repository page. Closes gitpoint#103.

* Fixed some merge issues

* Fixing some more merging issues

* Forgot to add myself as a contributor.

* Fetching user data and fetching repository data have been moved into their own functions.

* Fixed some merge issues.

* Renamed the function that fetches the information to be a bit more descriptive

* Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor.

* Fixed some merge issues, _again_

* Added pull to refresh to the non auth profile screen. Other minor improv.

* Fixing indentation inside of `<ScrollView />`

* Removing extra newline

* Adding a newline between our components and vendor components.

* Added myself as a contributor. Code and Bug Reports

* Valid NPM versions need to include three parts (x.y.z)

* Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh.

* Pull down to refresh now in Issue/PR page (comment list)

* Fixed some merging issues and yarn lockfile

* Organizations are now refreshable

* Better behavior on the AuthUser pull to refresh

* Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile

* Refreshing on Issues (specifically) works again

* Used '!!' instead of '|| false' as per suggestion 

Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined.

* Add a (watching) label that shows when a user is watching a repo already.

* Fixed to look like gitpoint/master

* feat(repository): fixed location of Watchers label

* Minor code change to keep consistent with the style of the rest of the repo

* docs: improve word choice (gitpoint#244)

* Improved CONTRIBUTING.md

* Improved contributing.md

* docs(README.md): add contributor

* fix(repo): Show repo prefix for search repo result (gitpoint#254)

* fix(repo): hide issues section in forked repo (gitpoint#257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned enhancement has pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SammyIsra @andrewda @housseindjirdeh