Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repo): Show repo prefix for search repo result #254

Merged
merged 1 commit into from Aug 16, 2017
Merged

fix(repo): Show repo prefix for search repo result #254

merged 1 commit into from Aug 16, 2017

Conversation

reyhansofian
Copy link
Contributor

@reyhansofian reyhansofian commented Aug 15, 2017 •
edited by lex111

Closes #252

  • show repo prefix

Preview

image

lex111
lex111 approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great start and welcome! 👍

housseindjirdeh
housseindjirdeh approved these changes Aug 16, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks a million for this :)

@housseindjirdeh housseindjirdeh merged commit d7bb321 into gitpoint:master Aug 16, 2017
reyhansofian added a commit to reyhansofian/git-point that referenced this pull request Aug 16, 2017
@reyhansofian
merge master (#1)
42cb797 
* docs(README.md): add translation instruction (gitpoint#255)

* chore(commit): Make the repo Commitizen-friendly (gitpoint#240)

* chore(commit): Make the repo Commitizen-friendly

* docs(contributors): change my profile url

* docs(CONTRIBUTING.md): add information about Commitizen

* docs(CONTRIBUTING.md): move translations snippet

* docs(CONTRIBUTING.md): update commitzen snipper grammar

* fix(comment-input): add new lines when writing issue comments on Android (gitpoint#207)

* feat(repo): add label to show watch status (gitpoint#227)

* Added react-native-cli to avoid onboarding issues in the future

* Pull down to refresh implemented in profile page

* Pull down to refresh implemented in Repository page. Closes gitpoint#103.

* Fixed some merge issues

* Fixing some more merging issues

* Forgot to add myself as a contributor.

* Fetching user data and fetching repository data have been moved into their own functions.

* Fixed some merge issues.

* Renamed the function that fetches the information to be a bit more descriptive

* Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor.

* Fixed some merge issues, _again_

* Added pull to refresh to the non auth profile screen. Other minor improv.

* Fixing indentation inside of `<ScrollView />`

* Removing extra newline

* Adding a newline between our components and vendor components.

* Added myself as a contributor. Code and Bug Reports

* Valid NPM versions need to include three parts (x.y.z)

* Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh.

* Pull down to refresh now in Issue/PR page (comment list)

* Fixed some merging issues and yarn lockfile

* Organizations are now refreshable

* Better behavior on the AuthUser pull to refresh

* Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile

* Refreshing on Issues (specifically) works again

* Used '!!' instead of '|| false' as per suggestion 

Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined.

* Add a (watching) label that shows when a user is watching a repo already.

* Fixed to look like gitpoint/master

* feat(repository): fixed location of Watchers label

* Minor code change to keep consistent with the style of the rest of the repo

* docs: improve word choice (gitpoint#244)

* Improved CONTRIBUTING.md

* Improved contributing.md

* docs(README.md): add contributor

* fix(repo): Show repo prefix for search repo result (gitpoint#254)

* fix(repo): hide issues section in forked repo (gitpoint#257)
@chinesedfan
Copy link
Member

@housseindjirdeh Please notice that /src/user/screens/repository-list.screen.js also uses the same component. So this PR changes behaves in that page.

All repositories of that page belong to the same user and share the same prefix. Does it redundant?

@chinesedfan chinesedfan mentioned this pull request Oct 2, 2017
Merged
@housseindjirdeh
Copy link
Member

@chinesedfan have no idea how I missed this :(

You're 100% right and I've pushed a commit to #409 so that it doesn't show for the current active user's list of repos. Everywhere else it would still show.

@chinesedfan
Copy link
Member

@housseindjirdeh Never mind. I know maintaining such a great project is very busy. Even watched, I receive lots of notifications everyday. 😆

@housseindjirdeh
Copy link
Member

Haha before GitPoint I would rarely get notifications. My notifications list becomes massive everyday now :O

But with that new Mark all notifications as read feature by @lex111, things might just be a lot better 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 approved these changes

@andrewda andrewda andrewda approved these changes

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repository search: show user/organisation prefix
5 participants
@reyhansofian @chinesedfan @housseindjirdeh @lex111 @andrewda