docs: improve word choice #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge patch-1 with master
Antoine38660
approved these changes
Aug 13, 2017
andrewda
approved these changes
Aug 13, 2017
andrewda
changed the title
housseindjirdeh
approved these changes
Aug 14, 2017
There was a problem hiding this comment.
Thanks so much for this @cameronsamuels <3
Don't forget to add yourself as a contributor with yarn contributors:add! Let me know if you would like it as part of this PR or just have this merged in, don't mind either way :)
|
If you can make me listed as a contributor in this PR, that will be preferred. I am not familiar with react native or yarn. Thanks! |
andrewda
changed the title
|
@cameronsamuels you have to run |
andrewda
changed the title
|
👍 done, just added you :) |
reyhansofian
added a commit
to reyhansofian/git-point
that referenced
this pull request
Aug 16, 2017
* docs(README.md): add translation instruction (gitpoint#255) * chore(commit): Make the repo Commitizen-friendly (gitpoint#240) * chore(commit): Make the repo Commitizen-friendly * docs(contributors): change my profile url * docs(CONTRIBUTING.md): add information about Commitizen * docs(CONTRIBUTING.md): move translations snippet * docs(CONTRIBUTING.md): update commitzen snipper grammar * fix(comment-input): add new lines when writing issue comments on Android (gitpoint#207) * feat(repo): add label to show watch status (gitpoint#227) * Added react-native-cli to avoid onboarding issues in the future * Pull down to refresh implemented in profile page * Pull down to refresh implemented in Repository page. Closes gitpoint#103. * Fixed some merge issues * Fixing some more merging issues * Forgot to add myself as a contributor. * Fetching user data and fetching repository data have been moved into their own functions. * Fixed some merge issues. * Renamed the function that fetches the information to be a bit more descriptive * Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor. * Fixed some merge issues, _again_ * Added pull to refresh to the non auth profile screen. Other minor improv. * Fixing indentation inside of `<ScrollView />` * Removing extra newline * Adding a newline between our components and vendor components. * Added myself as a contributor. Code and Bug Reports * Valid NPM versions need to include three parts (x.y.z) * Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh. * Pull down to refresh now in Issue/PR page (comment list) * Fixed some merging issues and yarn lockfile * Organizations are now refreshable * Better behavior on the AuthUser pull to refresh * Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile * Refreshing on Issues (specifically) works again * Used '!!' instead of '|| false' as per suggestion Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined. * Add a (watching) label that shows when a user is watching a repo already. * Fixed to look like gitpoint/master * feat(repository): fixed location of Watchers label * Minor code change to keep consistent with the style of the rest of the repo * docs: improve word choice (gitpoint#244) * Improved CONTRIBUTING.md * Improved contributing.md * docs(README.md): add contributor * fix(repo): Show repo prefix for search repo result (gitpoint#254) * fix(repo): hide issues section in forked repo (gitpoint#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved word choice and sentence structure.