Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ react ] add module style option #26

Closed
Giuliano1993 opened this issue Nov 29, 2023 · 3 comments · Fixed by #45
Closed

[ react ] add module style option #26

Giuliano1993 opened this issue Nov 29, 2023 · 3 comments · Fixed by #45
Assignees

Comments

@Giuliano1993
Copy link
Owner

It would be nice to have, as a styling option for react, the possibility use modules styling

@fmineo
Copy link
Contributor

fmineo commented Nov 30, 2023

Hi, I'd like to take charge of integrating this feature!

I was thinking we could add an extra question once react is selected as the framework: "Do you want to use module styling?" If the answer is no, the flow continues as usual. If yes, we'll create not only the component but also the css module already imported into the component.

Do you think this is a good approach?

@Giuliano1993
Copy link
Owner Author

Hi @fmineo ! You're welcome to take on this issue! Yes I think this can be a good approach! When the wizard ends you should not only copy the template but also the module!
Not an expert about React, but does the module for styling goes in the same folder of the component, in that case?

@fmineo
Copy link
Contributor

fmineo commented Dec 1, 2023

Hi @Giuliano1993, usually a css module can be found in any folder. However, for simplicity I would say to create the css module in the same folder as the component.

fmineo added a commit to fmineo/make-js-component that referenced this issue Dec 1, 2023
…creation of the React component

During the steps of the wizard, once React is selected as the framework, you will be prompted to
choose a CSS framework. In this list of options, the 'CSS Module' option has been added. If
selected, a new template is used for component generation, and the CSS module is generated and
imported into the new component.

closes Giuliano1993#26
@fmineo fmineo mentioned this issue Dec 1, 2023
Giuliano1993 added a commit that referenced this issue Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants