-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect asset pipeline availability #1
Comments
Is there any reason this stuff can't be cached in akamai sanely and just shared with everyone? |
That'd be useful for most projects, but would give the SSL insecure elements error for some projects. GitHub projects should definitely use the same assets though. |
The urls can be hardcoded and delegated to akamai without camo integration and knowing about SSL. I almost wish we didn't have secret keys in camo. We can't trivially evict shit out of akamai, we can just update the key but tons of older cached links will still live on. :\ |
But when this becomes opensource, we'll want to give users the option of how to serve assets. Since emoji is the only case, I think it's ok to leave it hardcoded relative to the gem and not support the asset pipeline until someone asks for it. Vote to close? |
In the github app, the emoji icons are frozen to public/images, and urls to images are coded relative to the value of
:asset_root
. It'd be preferable to detect the availability of the asset-pipeline and useasset_path
when it's available.The text was updated successfully, but these errors were encountered: