Import of corpus module should involve testing for completeness

[gkunter]

Originally reported by: gkunter (Bitbucket: gkunter, GitHub: gkunter)

---

ISSUE:
Currently, corpus modules are imported in Session.init() without any testing. In particular, there is no test whether the corpus Resource class provides all fields required to do the requested query. Such testing only takes place in some of the sql_string_xxx functions, so the script may, for instance, abort after the query during output.

SOLUTION:
First of all, a clear catalogue of what is required for a resource description is needed (see also Issue #11). Once that is established, BaseResource should implement a method validate() that is called in Session.init() after Corpus is initialized. This method should abort with an instructive error message if any required variable is missing.

---

• Bitbucket: https://bitbucket.org/gkunter/coquery/issue/13

[gkunter]

Original comment by gkunter (Bitbucket: gkunter, GitHub: gkunter):

---

Now that the corpus modules are created by corpusbuilder.py and derived classes, this issue is less relevant. Essentially, it is the task of the installer to ensure that the table description is complete.

[gkunter]

Original comment by gkunter (Bitbucket: gkunter, GitHub: gkunter):

---

Corpus installers and corpus modules are now validated by Coquery before they are executed. This validation reduces the chance of security risks, and ensures that at least the required classes are present.

It is still possible, however, that a corpus installer produces faulty corpus modules. This problem is delegated to the corpus installer maintainers, though.