-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS AST compilation (blendmaster fork) #481
Comments
👍 |
Hey, gkz and Nami-doc, I'm pretty excited about this too. I just wish I had more time to work on it. One pertinent question is that of inline JS support. Right now, my branch throws an error if the plain JS AST node is encountered, (which is fortunately nowhere in the compiler). Furthermore, I can't think of a good way to take a little snippet of JS and mix it back into the AST. Does CSR support JS inline? Also, if anybody with more free time than me would like to help, you should be able to jump in with the strategy described in the readme: https://github.com/blendmaster/LiveScript/tree/esprima#how-to-develop It's really close on a lot of the test files. The main discrepancy is the use of temporary variables. The kinda-sorta-one-pass compiler is able to "free" temporary vars by compiling a string earlier than we can compile to JS. I think changing the Other stuff to do would be general code quality and documentation in Also, re: source maps, once LS AST -> JS AST works, we'll have to add the column number to |
CSR uses |
Huh, so it does. Not the most efficient thing I guess, but at least it's mostly backwards compatible. http://michaelficarra.github.io/CoffeeScriptRedux/#try:for%20a%20in%20%60some%20stuff%60%0A%20%20c |
Yeah, a direct call to |
timeline:
|
I forgot about this! I'll have to take a look again sometime |
https://github.com/blendmaster/LiveScript/tree/esprima
@blendmaster
wow!
I was thinking of doing something like this in the future, but you are doing it!
The text was updated successfully, but these errors were encountered: