Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font rendered very blurry -- maybe scaling issue? #1124

Closed
WhyNotHugo opened this issue Aug 23, 2021 · 8 comments
Closed

Font rendered very blurry -- maybe scaling issue? #1124

WhyNotHugo opened this issue Aug 23, 2021 · 8 comments
Labels
blocked This issue can't be solved because of another problem. cant-reproduce Firenvim's maintainer cannot reproduce this issue. host:firefox This issue only happens with Firefox

Comments

@WhyNotHugo
Copy link

  • OS Version: linux x86-64
  • Browser Version: Firefox 91.0
  • Browser Addon Version: 0.2.8
  • Neovim Plugin Version: master 97f4794

What I tried to do

Using firenvim on Linux (with desktop scaling to 1.5x, which I suspect must be related).

What happened

Text renders very blurry and very large. The blurriness is a bit hard to compare due to how screenshots get compressed:

2021-08-23T18:02:54,220358387+02:00

Firefox+firenvim on the left, neovim on alacritty with font size 11 on the right.

I also noticed that the command bar is misaligned, which is what actually makes me thing this might be related to desktop scaling somehow.

2021-08-23T18:04:45,173076789+02:00

@glacambre
Copy link
Owner

Yep, that does sound like a scaling issue - very probably the same as #972 and #869.

Problem is, I can't reproduce it, so I can't fix it :/.

I also noticed that the command bar is misaligned

The command bar is vertically and horizontally centered, that's why it doesn't necessarily align with the grid. I think it's great that way - it makes the fact that it's a separate UI element obvious.

@glacambre glacambre added blocked This issue can't be solved because of another problem. cant-reproduce Firenvim's maintainer cannot reproduce this issue. host:firefox This issue only happens with Firefox labels Aug 23, 2021
@WhyNotHugo
Copy link
Author

What desktop are you using? You should be able to run sway (a wayland compositor) nested inside another X11 or Wayland session on Linux. Not sure about other platforms.

@WhyNotHugo
Copy link
Author

Oh, I though the command bar would be aligned to the bottom as in regular neovim. Why does it get centred?

@glacambre
Copy link
Owner

glacambre commented Aug 24, 2021

You should be able to run sway (a wayland compositor) nested inside another X11 or Wayland session on Linux. Not sure about other platforms.

Yes, I am running sway. Changing the scale of a screen (sway output VGA-1 scale 1.5) makes everything blurry on my computer, not just firenvim. So I'm not experiencing the same issue as you are and can't fix yours.

Oh, I though the command bar would be aligned to the bottom as in regular neovim. Why does it get centred?

Neovim's UI protocol lets UIs decide whether they want to render the command line themselves or let Neovim do it. By default, Firenvim renders the command line itself as this saves a line of screen estate, which is important because the textareas Firenvim operates on are frequently just a few lines tall. If you would rather have neovim render the command line, set the cmdline setting to neovim.

@WhyNotHugo
Copy link
Author

Scale 1.5 will render XWayland apps blurry (but native apps should not be terrible, "it depends").

Can you try scale 2? That should be nice and sharp.

@glacambre
Copy link
Owner

scale 2 is sharp for both firefox and firenvim on my computer.

@glacambre
Copy link
Owner

This issue probably has been fixed by the merge of #1385. Let me know if the problem persists and I'll re-open.

@WhyNotHugo
Copy link
Author

#1385 sounds like it's a fix for the issue. I'll set up firenvim again and give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue can't be solved because of another problem. cant-reproduce Firenvim's maintainer cannot reproduce this issue. host:firefox This issue only happens with Firefox
Projects
None yet
Development

No branches or pull requests

2 participants