Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom chromosome color for GWAS track #46

Open
ladyson1806 opened this issue Jun 26, 2023 · 4 comments
Open

Custom chromosome color for GWAS track #46

ladyson1806 opened this issue Jun 26, 2023 · 4 comments

Comments

@ladyson1806
Copy link

ladyson1806 commented Jun 26, 2023

Hi @paul-shannon!

Last year, I pointed you out an issue about a color bug for GWAS tracks in igvR (the whole story here). It is still there in igvShiny. As you mentioned in the post, the igv.js team updated their code to solve the issue, so it could be great to get an update of that part of the code to use it in igvShiny.

Nevertheless, I actually found your code implementation way simpler to use. It could be nice to add this feature to the GWASTrack function of the igvShiny package.

Again, thank you so much for your hard work on these packages, and for keeping them maintained.
Have a nice day,

Best regards - Savvy

@paul-shannon
Copy link
Collaborator

@ladyson1806, Hi Savvy. I regret to say that I will not have time to work on this any time soon. I have just retired from the Institute for Systems Biology. I have new (non-biology) projects keeping me very busy - too busy to work on this.

Maybe you could take it on, submit a PR?

@ladyson1806
Copy link
Author

Thank you for your quick answer @paul-shannon.
For sure, I will make a try!

@gladkia
Copy link
Owner

gladkia commented Jan 13, 2024

Hi, @ladyson1806.

What's the status of this issue? Do you still consider this feature a high priority? If so, do you want to help me with it :)?

@ladyson1806
Copy link
Author

ladyson1806 commented Jul 11, 2024

Hi @gladkia,

Sorry for the delay of my answer!
Short answer, I don't think this specific feature is a super high priority.
But there will be similar requests as mine for sure.

Suggestions:

  • Having only two colors (black and grey) to just distinct with minimum color information where each chromosome starts and ends.
  • Custom color based on the number of the chromosomes, similarly as the original feature (just make sure that the proposed palettes are color-blinded friendly).

There is no rush on this issue, but if you manage to add those options, I will use them for sure! Thank you!

I'm citing the library in my paper (currently under reviewed) and we have deployed a web page relying on this package, so I'm happy to help you on igvShiny's improvement.

The, you can use our study as a user-case example of this app!

Have a nice day - Savvy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants