Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extension icon action open a new tab page #17

Closed
kmjennison opened this issue Mar 25, 2019 · 5 comments · Fixed by #41
Closed

Make extension icon action open a new tab page #17

kmjennison opened this issue Mar 25, 2019 · 5 comments · Fixed by #41

Comments

@kmjennison
Copy link
Contributor

No description provided.

@blueputty01
Copy link
Contributor

Is this still open? I'd love to work on this.

@kmjennison
Copy link
Contributor Author

@blue-putty Yes, feel free to. Thanks!

blueputty01 added a commit to blueputty01/tab-extensions that referenced this issue Jun 30, 2021
@blueputty01
[gladly-team#17] action event handler
142ea62 
added event handler for icon click to open new tab
blueputty01 added a commit to blueputty01/tab-extensions that referenced this issue Jun 30, 2021
@blueputty01
[gladly-team#17] declaration for action event
4062c7c 
must have action key for icon click event handler to work
blueputty01 added a commit to blueputty01/tab-extensions that referenced this issue Jun 30, 2021
@blueputty01
[gladly-team#17] firefox icon click property
39b4327
blueputty01 added a commit to blueputty01/tab-extensions that referenced this issue Jul 14, 2021
@blueputty01
[gladly-team#17] event handlers for icon click
e16ba3d
@blueputty01
Copy link
Contributor

blueputty01 commented Jul 14, 2021 •
edited

@kmjennison
Currently, the Edge extension is on Manifest V2, which uses chrome.browserAction to handle icon action events. However, this was changed to chrome.action in Manifest V3, which is what the Chrome extension is on. Should I update the jest configuration to concurrently include the browserAction and action properties or change the Edge extension to Manifest V3?

@kmjennison
Copy link
Contributor Author

@blue-putty If you'd like to open a PR to first update the Edge manifest to v3, that's welcome! If not, go ahead and use chrome.browserAction, and we'll update the API later when we update the manifest version. Thanks!

@blueputty01
Copy link
Contributor

@kmjennison Thanks! I've opened #40 for the Edge manifest update.

@kmjennison kmjennison mentioned this issue Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make extension icon open a tab on click blueputty01/tab-extensions
2 participants
@kmjennison @blueputty01