Make extension icon open a tab on click #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added event handler for icon click to open new tab
must have action key for icon click event handler to work
originally console.log, now console.error
two unit tests for same function
removed redundant new line
added browser_action property
removed test for redundant url
|
Thanks for this contribution! Just a heads up, I'm OOO and won't get around to reviewing this for a week or two. |
kmjennison
requested changes
Aug 5, 2021
| @@ -14,7 +14,8 @@ | |||
| "background": { | |||
| "service_worker": "ext-background.js" | |||
| }, | |||
| "action": {}, | |||
There was a problem hiding this comment.
Please add a test to each test-manifest.js to simply verify this value. It would be helpful to comment in the test that an empty object activates the browser action icon so is different from an undefined action value.
| @@ -56,14 +56,19 @@ test('sets the post-uninstall URL', () => { | |||
| .toHaveBeenCalledWith('https://tab.gladly.io/newtab/uninstalled/') | |||
| }) | |||
|
|
|||
| test('gracefully handles errors with setting the post-uninstall URL', () => { | |||
There was a problem hiding this comment.
It looks like you accidentally replaced an existing test. Please re-add that test.
add post-uninstall url error handling
Manifest V2 uses browserAction key; V3 uses action key
browser_action property must exist for icon to be shown in toolbar
kmjennison
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17.
Changes proposed in this PR:
actionandbrowser_actionproperties to respective Jest API mocks