impossible detect curly in encapsed

[alexander-akait]

Input:

$juices = ['FOO' => 1];

echo "He drank some $juices[FOO] juice.";
echo "\n";
echo "He drank some ${juices['FOO']} juice.";
echo "\n";
echo "He drank some {$juices['FOO']} juice.";

Impossible detect ${ and } for first example. Maybe we can add options syntax:

1. syntax: simple, curly: false
2. syntax: simple, curly: true
3. syntax: complex

[ichiriac]

👍 I'll fix it soon

[alexander-akait]

Looks due this problem we break code:
Input:

$var = "This is my array value: $anArray[key]";
$var = "This is my array value: {$anArray[key]}";

Output:

$var = "This is my array value: $anArray[key]";
$var = "This is my array value: $anArray[key]";

Second expression output (with { and } no):

PHP Warning:  Use of undefined constant key - assumed 'key'

[alexander-akait]

I look on https://github.com/nikic/PHP-Parser/, they don't have information about { and }. After investigate and testing difference examples of code i find what we should introduce EncapsedItem node and have curly property for this and expression (maybe better name) property that have variable/*lookup/call node. It is allow to avoid adding curly to variable/*lookup/call nodes and save ast clear.

Example.

Input:

"{$var}";

AST:

{
      "kind": "encapsed",
      },
      "value": [
        {
                "kind": "encapseditem",
                "curly" : "true",
                "expression":  {
                      "kind": "variable",
                      "name": "var",
                      "byref": false,
                      "curly": false
                }
        }
      ],
      "type": "string"
    }

Input:

"$var";

AST:

{
      "kind": "encapsed",
      },
      "value": [
        {
                "kind": "encapseditem",
                "curly" : "false",
                "expression":  {
                      "kind": "variable",
                      "name": "var",
                      "byref": false,
                      "curly": false
                }
        }
      ],
      "type": "string"
    }

Input:

"${var}";

AST:

{
      "kind": "encapsed",
      },
      "value": [
        {
                "kind": "encapseditem",
                "curly" : "false",
                "expression":  {
                      "kind": "variable",
                      "name": "var",
                      "byref": false,
                      "curly": true
                }
        }
      ],
      "type": "string"
    }