Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] comment location overlaps with node location for static node #199

Closed
alexander-akait opened this issue Oct 9, 2018 · 4 comments
Closed
Assignees
Labels
investigating minor Minor issue - does not impact the parser too much (edge cases)

Comments

@alexander-akait
Copy link
Collaborator

Input:

// Comment
static
    // Comment
    $a // Comment
    // Comment
    =
    // Comment
    2021;
@ichiriac
Copy link
Member

Not sure that's a bug, here the AST output :
image

The comment includes the last "\n" char, so it ends at the 18th offset position. The static node starts at the 18th offset, in principle it's not an overlap.

Or do you mean it overlaps with inner comments ?

@ichiriac
Copy link
Member

@evilebottnawi ping ?

@alexander-akait
Copy link
Collaborator Author

@ichiriac I think problem on our side, don't have time on this issue right now and it is not high priority issue, i will investigate in near future and close issue if problem on our side and send a PR with fix if problem here

@ichiriac ichiriac added the minor Minor issue - does not impact the parser too much (edge cases) label Jan 7, 2019
@ichiriac ichiriac added this to the 3.1.0 milestone Jan 7, 2019
@ichiriac ichiriac assigned alexander-akait and unassigned ichiriac Jan 7, 2019
@alexander-akait
Copy link
Collaborator Author

Fixed after implement new ast for static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating minor Minor issue - does not impact the parser too much (edge cases)
Projects
None yet
Development

No branches or pull requests

2 participants