Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IFD writing when the "--legacy" option is used #9

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

melissalinkert
Copy link
Member

See #8

With this PR, the following should work:

$ bioformats2raw CMU-1.svs CMU-1.n5
$ raw2ometiff CMU-1.n5 CMU-1-legacy.ome.tiff --legacy
$ raw2ometiff CMU-1.n5 CMU-1.ome.tiff
# with private Bio-Formats 5.9:
$ showinf -noflat CMU-1-legacy.ome.tiff -omexml -nopix
# with Bio-Formats 6.x:
$ showinf -noflat CMU-1.ome.tiff -omexml -nopix

The resolutions should match between the two output files; each should have a pyramid with 9 resolutions. There should be no validation errors when displaying the OME-XML. tiffdump should confirm that there are no SubIFD tags in the CMU-1-legacy.ome.tiff file.

/cc @douglasrennick, @emilroz, @chris-allan

@melissalinkert melissalinkert mentioned this pull request Nov 27, 2019
@chris-allan chris-allan merged commit 639c236 into glencoesoftware:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants