Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Surface error messages received from Prometheus #11

Closed
glenn-m opened this issue Mar 31, 2019 · 0 comments
Closed

Surface error messages received from Prometheus #11

glenn-m opened this issue Mar 31, 2019 · 0 comments
Assignees
@glenn-m
Labels
enhancement 🚀 New feature or request

Comments

@glenn-m
Copy link
Owner

glenn-m commented Mar 31, 2019

The current error messages raised when we receive a non-200 status code are very basic.

We should be parsing JSON object returned by Prometheus to enrich our error messages.
@glenn-m glenn-m mentioned this issue Mar 31, 2019
Merged
@konradzdeb konradzdeb assigned konradzdeb and unassigned konradzdeb Apr 1, 2019
@konradzdeb konradzdeb mentioned this issue Apr 1, 2019
Closed
@glenn-m glenn-m added the enhancement 🚀 New feature or request label Apr 1, 2019
konradzdeb added a commit to konradzdeb/promR that referenced this issue Apr 1, 2019
@konradzdeb
Documentation
02189fb 
Created documentation for the sample data sets.
Guideines:
http://r-pkgs.had.co.nz/data.html#documenting-data

Issue glenn-m#11

Signed-off-by: Konrad Zdeb <konrad.zdeb@me.com>
konradzdeb added a commit to konradzdeb/promR that referenced this issue Apr 1, 2019
@konradzdeb
Testing
704037c 
Created set of tests on sample metrics included in the package
Can be further expanded to account for more operations on metrics results, such as cleaning column names, etc.
Issue glenn-m#11.

Signed-off-by: Konrad Zdeb <konrad.zdeb@me.com>
@konradzdeb konradzdeb mentioned this issue Apr 1, 2019
Merged
@glenn-m glenn-m self-assigned this Apr 2, 2019
@glenn-m glenn-m closed this as completed Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glenn-m glenn-m

Labels
enhancement 🚀 New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glenn-m @konradzdeb