-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in any file starting with underscore triggers recompilation of all files #17
Comments
Hi @sKopheK, This was by design. When Ritwick Dey created the extension it was built upon the generic principle of if it's a partial it could be included. So lets keep it simple and compile every file (settings dependant). There was an issue raised over in his repo that covered it. From what I remember it was decided that there wouldn't be a simple way of doing it without effecting the performance of the extension itself. However, for the life of me, I can't find the issue!
👍 if you want this adding |
thanks for the answer. switching from NetBeans IDE, I'm used to compiling only what was really changed - however there was still sass@ruby used and thus it was really slow, especially when recompiling all files. pitty, i won't be getting much performance boost when updating any of my many partials :( |
project with ~400 files suffers a lot by this restriction, please take a look on the video: when other files such as JS, PHP or HTML is there in the project folder, it gets even more slow because it waits until github scanning is done, which when it kicks in it goes into some kind of pending mode and watch is delayed by a couple of tens of seconds, but this might be an issue of git integration in the VS Code: https://drive.google.com/file/d/10cS_sAn-16MYWuVEMiwd8pSD6qaJBCu6/view?usp=sharing |
Yeah, I've seen and can feel your pain. I'll see if I can find anything to implement that'll help. It'll be slow to research, check, implement and test as I'm a bit rammed at the moment with work, uni study, etc, etc. It's not stopping me from investing time into my opensource stuff, but it's definitely reduced it compared to Christmas (when everything else stopped 😄 ) |
Doing some testing, I think the main delay comes from git integration (as you suggest). I can see the issue this causes when compiling everything, even those files that don't actually use the partial. Initial thoughts: compile a dictionary of file data (the file, the imports, the date it was last modified) and updating checking it as files save, are created and on launch. v5 coming soon so this may be a v6 or v5.x (depending on the possibility of breaking changes, 🤞 for none)
|
Hi, a little update on this one - was using NetBeans since its support for changed files solves the partials issue mentioned above, but as it runs sass compiler for every single changed file, it's also slow. Running the sass executable directly with |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I am experiencing some issues with this as well. I have read the above comments, and I understand why all files are generated. However I have multiple projects in my workspace, and saving a partial also generates files for my other projects. This might cause problems if other developers have working on the projects in the meantime. Would it be possible to have the extension only generate files for the related project (project root folder). Example: https://d.pr/i/qnAV4D |
...even when the file starting with underscore is not imported to any SCSS file, its changes trigger recomplication of all SCSS files
_x.scss
The text was updated successfully, but these errors were encountered: