Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for toContainEqual matcher #78

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Added support for toContainEqual matcher #78

merged 2 commits into from
Oct 19, 2020

Conversation

suzdalnitski
Copy link
Contributor

No description provided.

glennsl
glennsl approved these changes Oct 18, 2020
View reviewed changes
Copy link
Owner

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

glennsl
glennsl requested changes Oct 18, 2020
View reviewed changes
Copy link
Owner

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there's no test for not toContainEqual, which leaves some code uncovered in the tests. Could you add that as well?

@suzdalnitski
Copy link
Contributor Author

Done, please take another look!

@suzdalnitski suzdalnitski reopened this Oct 18, 2020
glennsl
glennsl approved these changes Oct 19, 2020
View reviewed changes
Copy link
Owner

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thanks!

@glennsl glennsl merged commit 9820415 into glennsl:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennsl glennsl glennsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suzdalnitski @glennsl