New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy syntax conflict #18

Closed
colintedford opened this Issue Feb 2, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@colintedford

colintedford commented Feb 2, 2015

I just belatedly updated from "Ponder Stibbons" to "Hrun" and my redirects using the #redirect syntax now show "1. redirect [pagename]" instead of redirecting. The ~~REDIRECT> style still works, but of course my existing redirects use #redirect because it's easier to type.

@jayqi

This comment has been minimized.

Show comment
Hide comment
@jayqi

jayqi Feb 20, 2015

Are you perhaps using the Creole plugin or some other plugin that uses # as the syntax for an ordered list? That looks to be what is happening. I am using Creole, and I have the same syntax conflict, so I've been stuck using the ~~REDIRECT> option.

jayqi commented Feb 20, 2015

Are you perhaps using the Creole plugin or some other plugin that uses # as the syntax for an ordered list? That looks to be what is happening. I am using Creole, and I have the same syntax conflict, so I've been stuck using the ~~REDIRECT> option.

@colintedford

This comment has been minimized.

Show comment
Hide comment
@colintedford

colintedford Feb 20, 2015

Aha, I am using the Creole plugin; thanks for dispelling the mystery.

colintedford commented Feb 20, 2015

Aha, I am using the Creole plugin; thanks for dispelling the mystery.

@colintedford colintedford changed the title from Easy syntax not working to Easy syntax conflict Feb 21, 2015

@glensc glensc added the question label Oct 13, 2015

@glensc

This comment has been minimized.

Show comment
Hide comment
@glensc

glensc Sep 24, 2016

Owner

looks like parser::parse():118 prepends \n to document and creole matches \n# first, breaking pageredirect plugin able to match full word

so even if your document content is: #redirect start when document is parsed it becames \n#redirect start\n

and here's creole pattern that is overly greedy: syntax_plugin_creole_listblock::connectTo()

             $this->Lexer->addEntryPattern(
                '\n[ \t]*[\#\*](?!\*)',
                $mode,
                'plugin_creole_listblock'
             );
Owner

glensc commented Sep 24, 2016

looks like parser::parse():118 prepends \n to document and creole matches \n# first, breaking pageredirect plugin able to match full word

so even if your document content is: #redirect start when document is parsed it becames \n#redirect start\n

and here's creole pattern that is overly greedy: syntax_plugin_creole_listblock::connectTo()

             $this->Lexer->addEntryPattern(
                '\n[ \t]*[\#\*](?!\*)',
                $mode,
                'plugin_creole_listblock'
             );
@glensc

This comment has been minimized.

Show comment
Hide comment
@glensc

glensc Sep 24, 2016

Owner

should be fixed with 36ebf4a

Owner

glensc commented Sep 24, 2016

should be fixed with 36ebf4a

@glensc glensc closed this Sep 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment