Fix undefined behaviour in X11 keypress handling #1989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`1 << 31` is undefined because 1 is an int, so the shift would set the sign bit
silversquirl
pushed a commit
to silversquirl/mach
that referenced
this pull request
Nov 12, 2021
1 task
slimsag
pushed a commit
to hexops/mach
that referenced
this pull request
Nov 15, 2021
slimsag
pushed a commit
to hexops/mach-glfw
that referenced
this pull request
Nov 15, 2021
7 tasks
1 task
slimsag
pushed a commit
to hexops/mach
that referenced
this pull request
Dec 28, 2021
repatch undefined behavior in GLFW which did not land yet and was accidentally removed when updating GLFW in #136 See glfw/glfw#1989 Fixes #149
slimsag
pushed a commit
to hexops/mach-glfw
that referenced
this pull request
Dec 28, 2021
repatch undefined behavior in GLFW which did not land yet and was accidentally removed when updating GLFW in #136 See glfw/glfw#1989 Fixes hexops/mach#149
slimsag
pushed a commit
to hexops/mach-glfw
that referenced
this pull request
Aug 26, 2022
slimsag
pushed a commit
to hexops/mach-glfw
that referenced
this pull request
Aug 26, 2022
repatch undefined behavior in GLFW which did not land yet and was accidentally removed when updating GLFW in #136 See glfw/glfw#1989 Fixes hexops/mach#149
slimsag
pushed a commit
to hexops/mach-glfw
that referenced
this pull request
Aug 26, 2022
repatch undefined behavior in GLFW which did not land yet and was accidentally removed when updating GLFW in #136 See glfw/glfw#1989 Fixes hexops/mach#149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 << 31is undefined because 1 is an int, so the shift would set the sign bitRelated to (and discovered in the same way as) #1986