Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for X11/GLX window transparency #715

Closed
wants to merge 4 commits into from
Closed

Conversation

@datenwolf
Copy link

datenwolf commented Feb 22, 2016

Added support for transparent X11/GLX windows.

@elmindreda elmindreda self-assigned this Feb 22, 2016
@elmindreda

This comment has been minimized.

Copy link
Member

elmindreda commented Feb 22, 2016

Thanks! I'll start a target branch for future pull requests based on this.

@datenwolf

This comment has been minimized.

Copy link
Author

datenwolf commented Feb 22, 2016

Just FYI: As obvious by the commit message I also took care about the EGL codepath. Apparently Mesa's EGL implementation (at least for the Intel integrated graphics in my notebook) will not report visuals with picture format that has a nonzero alpha mask. However it works flawlessly with NVidia proprietary drivers! IMHO this is something that absolutely must be addressed by Mesa, since this is a feature disparity between GLX and EGL (Mesa's GLX does 0 != alpha_mask just fine), so someone should file a feature request (GLFW now provides easy to use test cases).

@chp-io

This comment has been minimized.

Copy link
Contributor

chp-io commented Feb 22, 2016

I also have been working on this for the past couple of days and support all three X11, OSX and Windows. Unlike @datenwolf I didn't add support for the EGL codepath.

@chp-io

This comment has been minimized.

Copy link
Contributor

chp-io commented Feb 22, 2016

I can remove X11 support from my fork to not conflict with @datenwolf . Let me know @elmindreda .

@elmindreda

This comment has been minimized.

Copy link
Member

elmindreda commented Feb 23, 2016

This has been merged to the transparent-window branch unmodified except for commit message fixes. Thank you!

@elmindreda elmindreda closed this Feb 23, 2016
@elmindreda elmindreda modified the milestone: 3.3 Feb 23, 2016
elmindreda added a commit that referenced this pull request Sep 19, 2017
This is a squashed extract of several commits, minimally edited to
ensure it compiles.

Related to #197.
Related to #715.
elmindreda added a commit that referenced this pull request Sep 19, 2017
Fixes #197.
Related to #663.
Related to #715.
Related to #723.
Related to #1078.
elmindreda added a commit that referenced this pull request Sep 19, 2017
This is a squashed extract of several commits, minimally edited to
ensure it compiles.

Related to #197.
Related to #715.
elmindreda added a commit that referenced this pull request Sep 19, 2017
Fixes #197.
Related to #663.
Related to #715.
Related to #723.
Related to #1078.
elmindreda added a commit that referenced this pull request Sep 27, 2017
This is a squashed extract of several commits, minimally edited to
ensure it compiles.

Related to #197.
Related to #715.
elmindreda added a commit that referenced this pull request Sep 27, 2017
This completes support for window framebuffer transparency on Windows,
macOS and X11.  Note that the hint/attribute may be renamed before
release to clarify its relationship to GLFW_OPACITY.

Fixes #197.
Closes #1079.
Related to #663.
Related to #715.
Related to #723.
Related to #1078.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.