Support for resize operation on borderless windows #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the function ```glfwResizeWindow```, that allows to resize windows without borders.
The function ```glfwResizeWindow``` now supports the Windows platform.
This is an initial implementation and still isn't working.
|
The Wayland implementation is fixed by #992. |
elmindreda
added
enhancement
jadahl
approved these changes
Apr 10, 2017
linkmauve
requested changes
Nov 17, 2017
| break; | ||
| case GLFW_WINDOW_BOTTOMRIGHT: | ||
| wlBorder = WL_SHELL_SURFACE_RESIZE_BOTTOM_RIGHT; | ||
| } |
There was a problem hiding this comment.
The absence of a default case will make compilers yell at you for having wlBorder potentially uninitialised, you should either initialise it at declaration, or (better imo) add a default case which assert(GLFW_FALSE) to tell the compiler this can never happen.
| break; | ||
| case GLFW_WINDOW_BOTTOMRIGHT: | ||
| wBorder = HTBOTTOMRIGHT; | ||
| } |
| break; | ||
| case GLFW_WINDOW_BOTTOMRIGHT: | ||
| xclient.data.l[2] = _NET_WM_MOVERESIZE_SIZE_BOTTOMRIGHT; | ||
| } |
| /*! @brief Starts a resize operation with the specified window. | ||
| * | ||
| * This function starts a resize operation on one of the borders of the | ||
| * specified window. |
There was a problem hiding this comment.
You should add a mention that this function must be called from a pointer event callback, otherwise it risks reacting to a different event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the functionality to resize a borderless window, by specifying the region relative to the resize operation:
GLFW_WINDOW_LEFTGLFW_WINDOW_TOPGLFW_WINDOW_RIGHTGLFW_WINDOW_BOTTOMGLFW_WINDOW_TOPLEFTGLFW_WINDOW_TOPRIGHTGLFW_WINDOW_BOTTOMLEFTGLFW_WINDOW_BOTTOMRIGHTThis is related with the issue #990.