Clicks on output

[polluxsynth]

Have a problem, release 2.0, as follows:

When playing one note after another, holding them down, sometimes a loud click is heard on the 5th and 6th note. It doesn't happen every time, one has to wait for about half a minute or so before the phenomenon occurs. If just playing the notes one at a time, it is usually not a problem, but occasionally it happens then too.

I've uploaded a .wav file of the audio output from the P600 at http://www.butoba.net/downloads/P600-clicks.wav . I simply took a picture of the patch used, at http://www.butoba.net/downloads/P600-patch.jpg . The purpose of the patch is to illustrate the effect, hence the low level of osc B, and the low amplifier sustain level, so that the new notes can be heard as they are played. It happens even if osc B is at zero, or the envelope sustain is at max. With the oscillators at max, the effect is less noticable, but still annoying.

[gligli]

Could you check if it's somehow related to filter cutoff?

[polluxsynth]

I don't have the machine at home right now, but I can check next time I get the chance.

[polluxsynth]

It looks as if removing the if(assigned) statement in synth.c:refreshVoice() would cause the CV updates to run continuously? Can you think of any disadvantage to doing that (other than it wastes resources as the voice is not being heard anyway, on the other hand, the CPU has to be able to handle all voices being active at any time anyway). Of course, if it indeed is the filter CV that causing the problem, I guess it would be sufficient to do a sh_setCV() on the filter CV S/H channel, in the else clause where the amp CV is updated?

[gligli]

Well, of course the CPU can handle all the voices playing and being updated at once, but then the pot scan rate becomes lower (they are scanned in the main loop, so when there's time left).
Still, If I can manage to get all the voices CVs contantly updated while not taking too much CPU time it would probably be better than the current way.

[gligli]

May be fixed by my last commits!

[polluxsynth]

Ok, great, can't wait to try this out although it looks like I won't get my hand on the P600 to test on until next week sometime. Thanks for your efforts!

[polluxsynth]

By the way, is the key assigned still reset when no voices are playing after your update?

[gligli]

Yes, no change in the assigner.

[polluxsynth]

Finally I can confirm that the alpha version at http://sfx.gligli.free.fr/zik/p600/dev/2014-08-22/ fixes this problem. Thanks! (Do you want me to close the issue, or will you close it when you've made the next release?)

[gligli]

Fixed by 1184aeb