Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

TSLint #68

Merged
merged 1 commit into from Nov 7, 2017
Merged

TSLint #68

merged 1 commit into from Nov 7, 2017

Conversation

t-sauer
Copy link
Contributor

@t-sauer t-sauer commented Nov 3, 2017

Added ember-cli-tslint to the blueprint and adjusted the code/config to pass the tests after initialisation.

import { ComponentManager, setPropertyDidChange } from '@glimmer/component';
import App from './main';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which rule is forcing this change? I don’t fully understand why the various import statements are moved around...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is caused by ordered-imports which is included in the recommended preset.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue do you prefer to disable the rule or keep the changes? I'd go with the changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not a giant fan of this specific rule, but meh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly the recommended preset comes with too much opinions about stylistic choices in my opinion. I prefer what ESLint is doing in their recommended preset (not including any stylistic choices at all) but as far as I know, no similar preset exists for TSLint.

@rwjblue rwjblue merged commit 8f70381 into glimmerjs:master Nov 7, 2017
@t-sauer t-sauer deleted the tslint branch November 7, 2017 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants