Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .travis.yml #5

Merged
merged 2 commits into from
Jan 12, 2017
Merged

Add .travis.yml #5

merged 2 commits into from
Jan 12, 2017

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Jan 12, 2017

No description provided.

rwjblue
rwjblue requested changes Jan 12, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add - "node" (alias for current stable version) to the list of node versions? Then this PR would match our general support matrix...

@dgeb dgeb force-pushed the travis branch 5 times, most recently from 306dc2d to 0e7e7ff Compare January 12, 2017 16:18
@dgeb dgeb merged commit 24ab033 into master Jan 12, 2017
@dgeb
Copy link
Member Author

dgeb commented Jan 12, 2017

Good call @rwjblue - I've added node to the test matrix.

Also, to support node 4 / npm 2, I had to make broccoli, broccoli-cli, and testem explicit devDeps here (even though they are already deps of glimmer-build). Not sure if there's a better alternative.

@dgeb dgeb deleted the travis branch January 12, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgeb @rwjblue