Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent TypeScript declarations #72

Closed
dfreeman opened this issue May 12, 2020 · 1 comment
Closed

Inconsistent TypeScript declarations #72

dfreeman opened this issue May 12, 2020 · 1 comment

Comments

@dfreeman
Copy link
Contributor

I've noticed that @glimmerx/component ships with TypeScript declarations, by virtue of not having a files entry that excludes its index.ts from being published.

@glimmerx/modifier and @glimmerx/helper, on the other hand, exclude the .ts files they have that re-export from their corresponding @glimmer packages.

Is that distinction intentional, or are all the @glimmerx packages meant to include TypeScript support out of the box?

@dfreeman
Copy link
Contributor Author

I think this has either been resolved or (more likely) I misdiagnosed the original situation. Either way, I don't think the problem I was describing here is actually a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant