-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config flag to stop template from local resolution #17
Conversation
Adds two tests:
|
}, | ||
collections: { | ||
routes: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we add types
in the routes
collection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thank you, adding this.
5916eac
to
501e44a
Compare
- Ensure a type only specifier does not fall back to a global resolution - Only look for a local lookup in the definitive collection
Ok, the approach her has changed. Two semantic differences land here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems much better than the original flag. We should continue thinking of a better long term solution (or disambiguate better in Ember itself).
One reason you might call this less than ideal is that |
disableLocalResolutionForTypes
to the config, permits a type to block being locally resolved in a given collection.edit: This summary is out of date. See #17 (comment)